Bug 1123364
Summary: | Plug-in updates do not get applied due to plug-in files using same version number but having older timestamp then already installed plug-in | ||
---|---|---|---|
Product: | [JBoss] JBoss Operations Network | Reporter: | Filip Brychta <fbrychta> |
Component: | Core Server | Assignee: | RHQ Project Maintainer <rhq-maint> |
Status: | CLOSED EOL | QA Contact: | Mike Foley <mfoley> |
Severity: | low | Docs Contact: | |
Priority: | unspecified | ||
Version: | JON 3.2.2 | CC: | fbrychta, loleary, mfoley, myarboro |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | JON 3.4.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-06-10 14:59:41 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Filip Brychta
2014-07-25 12:38:32 UTC
This is weird but it seems that this issue is caused by file timestamps. Unzip preserves timestamps and cp does not. When you use --preserve option for cp the issue is visible. Without this option it works. (In reply to Filip Brychta from comment #2) > This is weird but it seems that this issue is caused by file timestamps. > Unzip preserves timestamps and cp does not. When you use --preserve option > for cp the issue is visible. Without this option it works. The server will definitely look at timestamps. If the plugin version string is the same as the plugin version deployed in the server, the fallback is timestamp. If the timestamp is older than the plugins that are already installed, those plugins with the old timestamps are ignored. Moving into ER05 as didn't make the ER04 cut. I don't think this is a problem. If the versions are the same, the ones with the timestamps "win" - that's expected behavior. Is there something else I am misunderstanding about this BZ? This problem will affect only installations which have newer timestamp than jon-plugin-pack-eap-3.2.0.GA-update-01. This will probably happen only in testing environment. 1. install fresh jon3.2.2 2. copy original plugins - now you have plugins with timestamp == now, because cp command doesn't preserve timestamps 3. unzip jon-plugin-pack-eap-3.2.0.GA-update-01.zip -d jon-server-3.2.0.GA So plugins from step 3 have the same name but older timestamps because unzip preserves it. Am I right in understanding this as basically a user error? I will proactively close this as NOTABUG. If anyone disagrees with that, please move it back. Re-opening since there still seems to be a misunderstanding. Problem is caused by different behaviour of cp command and unzip command regarding file timestamps. Installation manual [1] instructs users to use cp command to copy plugin jar files but doc text in bz 1088652 instruct users to use unzip command directly. Previous facts lead to this situation: 1. (for some reason e.g. testing) install fresh (now) jon3.2.2 with jon-plugin-pack-eap-3.2.0.GA - so following installation manual you should use cp command to copy plugin jars -> plugin jars have timestamp == now, because cp command doesn't preserve timestamps 2. following doc text in bz 1088652: unzip jon-plugin-pack-eap-3.2.0.GA-update-01.zip -d jon-server-3.2.0.GA So plugin jar files extracted in step 2 have older timestamps (date when update-01 was released) than already installed plugins -> plugins from update-01 will be ignored. This is really a low priority edge case but it could be fixed easily just by updating doc text in bz 1088652 to follow the same logic as installation manual which is: - unzip jar files to /tmp - copy them to JON_SERVER_HOME/plugins directory 1 - https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Operations_Network/3.2/html/Installation_Guide/installing-plugins.html making this a documentation issue. see comment #11 for what is recommended for the documentation. Moving to CR01 as missed ER05 initial and extended cutoffs. JBoss ON is coming to the end of its product life cycle. For more information regarding this transition, see https://access.redhat.com/articles/3827121. This bug report/request is being closed. If you feel this issue should not be closed or requires further review, please create a new bug report against the latest supported JBoss ON 3.3 version. |