Bug 1123402
| Summary: | Review Request: awscli - AWS Command Line Interface | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Haïkel Guémar <karlthered> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | dustymabe, karlthered, lkundrak, lrintel, package-review, xavier |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-10 17:42:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1123397, 1123398, 1123399 | ||
| Bug Blocks: | |||
|
Description
Lubomir Rintel
2014-07-25 14:15:16 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/awscli.spec SRPM: http://v3.sk/~lkundrak/SRPMS/awscli-1.3.24-2.fc21.src.rpm Added Python 3 support. spec attached is different from the one provided in the srpm. I suggest moving the python3 BR below the python3 subpackage (not a blocker). (In reply to Haïkel Guémar from comment #2) > spec attached is different from the one provided in the srpm. Good catch; fixed. > I suggest moving the python3 BR below the python3 subpackage (not a blocker). I'd prefer not to (I find it cleaner for no good reason). Ping? pong (sorry, you'll hear from me today) There's probably a typo in the beginning, the build conditional is always the same. The %package & %description sections of the python3 subpackage are not guarded by the python3 condition. (In reply to Haïkel Guémar from comment #6) > There's probably a typo in the beginning, the build conditional is always > the same. Nope. There's a comment with an explanation above/ > The %package & %description sections of the python3 subpackage are not > guarded by the python3 condition. That one is correct too. Whether the package is created or not is determined by presence of %files section. Ping? Ping? Lubomir, while the review is stalled waiting for the reviewer, could you please update to latest version ? You're packaging 1.3.24 and the latest is 1.6.9. Please do so, the reviewer (me) was travelling quite a lot these last two months. At least, this week is the last one I'm travelling for 2014. SPEC: http://v3.sk/~lkundrak/SPECS/awscli.spec SRPM: http://v3.sk/~lkundrak/SRPMS/awscli-1.6.9-1.fc21.src.rpm ? The site where spec and src.rpm were hosed was not accessible during end of december.
I think that the R: python-botocore < 0.59.0 is incorrect, it prevents the installation of awscli on rawhide and the current version of awscli does not work with botocore < 0.64.0 (it imports at least the parsers module which doesn't exist before).
%{python2_sitelib}/%{name}/paramfile.py still have a shebang while it's not an executable script (could be fixed upstream btw).
Seems like this is in Fedora now: https://admin.fedoraproject.org/pkgdb/package/rpms/awscli/ closing |