Bug 1123808

Summary: [log-collector] no engine.log in the final archive
Product: [Retired] oVirt Reporter: Jiri Belka <jbelka>
Component: ovirt-engine-logcollectorAssignee: Sandro Bonazzola <sbonazzo>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 3.5CC: dcaroest, didi, ecohen, gklein, iheim, lveyde, rbalakri, stirabos, yeylon
Target Milestone: ---Keywords: Regression
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: integration
Fixed In Version: ovirt-3.5.0_rc1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1128839 (view as bug list) Environment:
Last Closed: 2014-10-17 12:24:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1122965, 1128839    

Description Jiri Belka 2014-07-28 10:00:37 UTC 
Description of problem:

$ tar tJf /tmp/sosreport-LogCollector-20140728114608.tar.xz | grep engine
./jb-ovirt35-2014072811391406540390/etc/httpd/conf.d/z-ovirt-engine-proxy.conf
./jb-ovirt35-2014072811391406540390/etc/httpd/conf.d/ovirt-engine-root-redirect.conf
./jb-ovirt35-2014072811391406540390/etc/selinux/targeted/modules/active/modules/cfengine.pp

where is engine.log and its friends?

# find /var/log/ovirt-engine/ -type f | wc -l
17

Version-Release number of selected component (if applicable):
ovirt-log-collector-3.5.0-0.1.master.20140715.gitf738f97.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1. engine-log-collector
2.
3.

Actual results:
archive does not contain important log files

Expected results:
should be there

Additional info:
2014-07-28 11:39:45::INFO::engine-log-collector::1340::root:: Gathering oVirt Engine information...
2014-07-28 11:40:57::INFO::engine-log-collector::1314::root:: Gathering PostgreSQL the oVirt Engine database and log files from localhost...
2014-07-28 11:45:17::INFO::engine-log-collector::1267::root:: Gathering information from selected hypervisors...
2014-07-28 11:45:17::INFO::engine-log-collector::709::root:: collecting information from 10.34.63.222
2014-07-28 11:46:08::INFO::engine-log-collector::767::root:: finished collecting information from 10.34.63.222
2014-07-28 11:46:32::INFO::engine-log-collector::1708::root:: Log files have been collected and placed in /tmp/sosreport-LogCollector-20140728114608.tar.xz.
The MD5 for this file is ea7c1da168dc18a0b6fb143ffda8c447 and its size is 100.8M
Comment 1 Jiri Belka 2014-07-28 10:02:24 UTC 
Maybe there should be a check if it really collects anything useful :)
Comment 2 Sandro Bonazzola 2014-07-29 11:50:35 UTC 
This affects EL6 only and it's due to an error while back-porting sos3 plugin to sos2 API.

The traceback is:
 Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/sos/sosreport.py", line 729, in  sosreport
    plug.setup()
  File "/usr/lib/python2.6/site-packages/sos/plugins/ovirt.py", line 71, in setup
    lines = self.callExtProg(pgrep)['output'].splitlines()
 TypeError: tuple indices must be integers, not str

A patch will follow in a few minutes.
Comment 3 Jiri Belka 2014-08-06 14:43:56 UTC 
ovirt-3.5.0_rc1 has latest ovirt-log-collector-3.5.0-0.1.master.el6.noarch which is from Wed 23 Jul 2014 01:09:43 PM CEST and does not contain the fix.

please provide new build and version. thx.
Comment 4 Sandro Bonazzola 2014-08-08 09:09:11 UTC 
There was an issue in oVirt jenkins[1], missing to add timestamp suffix to the built rpm. The ovirt-3.5-pre repository has now been updated with the right rpm (same rpm version and release due to jenkins issue) and should contain the fix. 

We're fixing the timestamp suffix issue so next rc shouldn't be affected

[1] https://fedorahosted.org/ovirt/ticket/231
Comment 5 Jiri Belka 2014-08-08 12:23:45 UTC 
ok now.

# tar tJf /tmp/sosreport-LogCollector-20140808141859.tar.xz | grep /var/log/ovirt-engine/
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/setup/
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/setup/ovirt-engine-setup-20140806113324-g6roac.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/setup/ovirt-engine-setup-20140722135804-1g2znn.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140805.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140731.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/console.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140803.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/ovirt-log-collector/
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/ovirt-log-collector/ovirt-log-collector-20140806162138.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/ovirt-log-collector/ovirt-log-collector-20140808141416.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140802.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140808.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140804.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140806.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/host-deploy/
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/host-deploy/ovirt-20140730150712-10.34.63.222-7278626f.log-20140801.gz
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/host-deploy/ovirt-20140808130529-10.34.63.223-513d8b3d.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/host-deploy/ovirt-20140805170012-10.34.62.205-535c8a1b.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/boot.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/server.log
./jb-ovirt35-2014080814141407500063/var/log/ovirt-engine/engine.log-20140801.gz

# rpm -qi ovirt-log-collector | grep 'Build Date'
Release     : 0.1.master.el6                Build Date: Tue 29 Jul 2014 01:57:53 PM CEST
Comment 6 Sandro Bonazzola 2014-10-17 12:24:15 UTC 
oVirt 3.5 has been released and should include the fix for this issue.