Due to a recent update on Javascript code a full page refresh on your browser might be needed.

Bug 1124099

Summary: Live Merge: Limit merge operations based on hosts' capabilities
Product: [Retired] oVirt Reporter: Greg Padgett <gpadgett>
Component: ovirt-engine-coreAssignee: Greg Padgett <gpadgett>
Status: CLOSED CURRENTRELEASE QA Contact: Kevin Alon Goldblatt <kgoldbla>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5CC: acanan, amureini, ecohen, gklein, gpadgett, iheim, lsurette, rbalakri, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: ovirt-3.5.0_rc1.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-17 12:44:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1109925    
Bug Blocks: 1073943    

Description Greg Padgett 2014-07-29 00:57:24 UTC
Not all hosts are capable of performing Live Merge operations.  Those that are will indicate it with a flag in the vdsm capabilities API (see bug 1109925).  Based on that flag, the engine will restrict Live Merge.

Comment 1 Kevin Alon Goldblatt 2014-10-06 14:36:49 UTC
Hi I tested the following regarding the blocking of the live merge feature based on the host version:

On a LIVE VM including block and nfs disks with 4 snapshots I tried deleting snapshots 2 and 3
On a LIVE VM including block and nfs disks with 4 snapshots I tried deleting snapshot DISKS from snapshots 2 and 3 

Results:
rhel 6.5 Live merge is blocked in the UI
rhel 7.0 Liver merge is blocked in the UI


Does this resolve this issue?

Comment 2 Greg Padgett 2014-10-08 18:00:32 UTC
(In reply to Kevin Alon Goldblatt from comment #1)
> Hi I tested the following regarding the blocking of the live merge feature
> based on the host version:
> 
> On a LIVE VM including block and nfs disks with 4 snapshots I tried deleting
> snapshots 2 and 3
> On a LIVE VM including block and nfs disks with 4 snapshots I tried deleting
> snapshot DISKS from snapshots 2 and 3 
> 
> Results:
> rhel 6.5 Live merge is blocked in the UI
> rhel 7.0 Liver merge is blocked in the UI
> 
> 
> Does this resolve this issue?

Half of it, I suppose :)

Looking at Adam's verification instructions in bug 1109925 comment 5, the points at which to test whether the engine is allowing live merge would be after numbers 3 and 11.  The engine should respect vdsClient's returned liveMerge = <"false"|"true"> value, and should correspondingly block (or not) the live merge operation in the UI.

Comment 3 Greg Padgett 2014-10-08 18:02:17 UTC
(That should say "vdsm's returned liveMerge [...] value".  Of course the value can be checked using vdsClient.)

Comment 4 Sandro Bonazzola 2014-10-17 12:44:54 UTC
oVirt 3.5 has been released and should include the fix for this issue.