Bug 1124813
| Summary: | jsonrpc: No call and return data logging | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Antoni Segura Puimedon <asegurap> | ||||
| Component: | vdsm | Assignee: | Piotr Kliczewski <pkliczew> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Antonin Pagac <apagac> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 3.5 | CC: | bazulay, bugs, ecohen, fromani, gklein, iheim, mgoldboi, rbalakri, ybronhei, yeylon | ||||
| Target Milestone: | --- | ||||||
| Target Release: | 3.5.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | infra | ||||||
| Fixed In Version: | v4.16.4 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-10-17 12:24:36 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 922584 [details]
vdsm.log
This is a vdsm.log that contains the jsonrpc operation
Note that the attachment is a full rotation of the log and that it happened pretty fast (no VMs running, only querying from the engine, I presume) 11:00-14:00 Same for virt flows, CC'ing myself. Verified in RHEVM Version: 3.5.0-0.11.beta.el6ev.
The messages when using jsonrpc are:
Thread-25::DEBUG::2014-09-22 14:57:03,800::__init__::467::jsonrpc.JsonRpcServer::(_serveRequest) Calling 'Host.setupNetworks' in bridge with {u'bondings': {}, u'networks': {u'ovirtmgmt': {u'remove': u'true'}, u'rhevm': {u'nic': u'eth0', u'mtu': u'1500', u'bootproto': u'dhcp', u'STP': u'no', u'bridged': u'true', u'defaultRoute': True}}, u'options': {u'connectivityCheck': u'true', u'connectivityTimeout': 120}}
Thread-25::DEBUG::2014-09-22 14:57:07,146::__init__::498::jsonrpc.JsonRpcServer::(_serveRequest) Return 'Host.setupNetworks' in bridge with {'message': 'Done', 'code': 0}
oVirt 3.5 has been released and should include the fix for this issue. |
Description of problem: When doing a network operation with xmlrpc we'd get the following in vdsm.log Thread-21::DEBUG::2014-07-30 13:38:11,414::BindingXMLRPC::1127::vds::(wrapper) client [10.34.61.242]::call setupNetworks with ({'10': {'nic': 'em2', 'vlan': '10', 'STP': 'no', 'bridged': 'true', 'mtu': '1500'}}, {}, {'connectivityCheck': 'true', 'connectivityTimeout': 120}) {} flowID [686033d4] Thread-21::DEBUG::2014-07-30 13:38:32,689::BindingXMLRPC::1134::vds::(wrapper) return setupNetworks with {'status': {'message': 'Done', 'code': 0}} With json rpc we only get (related to the call itself): Thread-23057::DEBUG::2014-07-30 13:32:44,126::__init__::462::jsonrpc.JsonRpcServer::(_serveRequest) Looking for method 'Host_setupNetworks' in bridge Without the extra information it is not possible for an administrator to study the logs to try to find what happened with a host, and it is even worse for a developer trying to analyze a bug Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1. Move to json rpc 2. Use the setupNetworks dialog to add a network to a host Actual results: There is only a logging entry for searching for Host_setupNetworks Expected results: There is logging for the input call data and for the call return data Additional info: