Bug 1124851
| Summary: | WebSocketProxy vdcoption requires a restart to become effective | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Simone Tiraboschi <stirabos> |
| Component: | RFEs | Assignee: | Marek Libra <mlibra> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavel Stehlik <pstehlik> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | --- | CC: | bugs, didi, gklein, iheim, mgoldboi, michal.skrivanek, oourfali, rbalakri, sbonazzo, yeylon, ykaul |
| Target Milestone: | ovirt-3.6.3 | Keywords: | Reopened |
| Target Release: | 3.6.3 | Flags: | michal.skrivanek:
ovirt-3.6.z?
ylavi: planning_ack? rule-engine: devel_ack+ ylavi: testing_ack? |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | virt | ||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: |
Feature: The WebSocketProxy VDC option(and a few others) can be updated without need to restart the engine.
Reason: Admin can change simple configuration without restarting the engine.
Result: Steps to reload the configuration on-the-fly:
- set: engine-config -s WebSocketProxy=NEW_VALUE
- refresh cache via REST API POST call, i.e.:
curl --silent --insecure --request POST --header "Accept: application/xml" --header "Content-Type: application/xml" --user "admin@internal:PWD" "http://localhost:8080/ovirt-engine/api/reloadconfigurations" --data '<action/>'
- refresh GUI: Ctrl+R
Support for reloading VDC options on-the-fly will be most probably dropped in oVirt 4.0.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-02 10:37:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1284409 | ||
| Bug Blocks: | |||
|
Description
Simone Tiraboschi
2014-07-30 13:03:34 UTC
Note that this isn't specific to this key - see [1]. Didn't find an existing bug for this feature - if you find one, you can close as duplicate. [1] http://www.ovirt.org/Features/ReloadableConfiguration Keys can either be set as reloadable, or not. Once they are set, one needs to issue an API call to /api/reloadConfigurations in order for the reload to occur. So, the bug shouldn't be on all configuration entries, but only to ones that aren't reloadable. So, in case of web socket proxy, virt team should determine whether it should be reloadable or not, and whether something needs to be done with it. Moving back to virt. currently it's not reloadable, I don't see any reason why it can't be... WebSocketProxy vdc_option has been set to Reloadable. To take effect without restarting the engine: - set: engine-config -s WebSocketProxy=NEW_VALUE - refresh cache via REST API POST call, i.e.: curl --silent --insecure --request POST --header "Accept: application/xml" --header "Content-Type: application/xml" --user "admin@internal:PWD" "http://localhost:8080/ovirt-engine/api/reloadconfigurations" --data '<action/>' - refresh GUI: Ctrl+R Since the 'reload' action is not recently implemented in the engine-config, these steps for reloading the configuration are added to the engine-config's man page and the usage() help message to improve user experience. From the discussion with the infra team: the Reloadable options are recently not supported, maybe in a future release. Handing the bug over to infra. We're not gonna make it reloadable. Closing it as WONTFIX. current REST API support for config reload is enough, and it works. moving back to virt to get in a simple fix as per comment #2 this is not really an RFE, it should have been like that since beginning and it does not require any real code change (In reply to Michal Skrivanek from comment #7) > current REST API support for config reload is enough, and it works. moving > back to virt to get in a simple fix as per comment #2 > > this is not really an RFE, it should have been like that since beginning and > it does not require any real code change As specified, we're deprecating it. You want to rely on it - your call. It won't be there in 4.0 for reasons I've described in the RFE related to reloaded configuration. I want to fix a wrongly designated parameter Note that from API point of view you need one release to deprecate, then remove in the next one. This request has been proposed for two releases. This is invalid flag usage. The ovirt-future release flag has been cleared. If you wish to change the release flag, you must clear one release flag and then set the other release flag to ?. Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA. Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA. Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA. Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA. Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA. Closing older BZs, if still happened, please reopen. |