Bug 1125197

Summary: Endless loop in Image.getChain if a volume chain has a cycle
Product: [Retired] oVirt Reporter: Nir Soffer <nsoffer>
Component: vdsmAssignee: Nir Soffer <nsoffer>
Status: CLOSED CURRENTRELEASE QA Contact: Raz Tamir <ratamir>
Severity: urgent Docs Contact:
Priority: high    
Version: 3.5CC: acanan, amureini, bazulay, danken, ecohen, gklein, iheim, mgoldboi, nsoffer, rbalakri, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: v4.16.2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-17 12:31:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
vdsm log showing the endless loop
none
Verification info none

Description Nir Soffer 2014-07-31 09:52:27 UTC
Created attachment 922866 [details]
vdsm log showing the endless loop

Description of problem:

If an image volume chain has a cycle, Image.getChain will loop forever, trying to sort the chain, until all memory is used.

Version-Release number of selected component (if applicable):
master as of 2014-07-31

How reproducible:
Always

Steps to Reproduce:
1. Create a cycle in volume parent uuids, for example, change volume parent to itself

Actual results:
getChain looping endlessly

Expected results:
getChain raise an exception since the volume chain is illegal.

Comment 1 Nir Soffer 2014-07-31 09:53:40 UTC
Respin from bug 1124498.

Comment 2 Nir Soffer 2014-08-01 12:29:04 UTC
Created attachment 923285 [details]
Verification info

This should help qe to verify this bug.

Comment 3 Dan Kenigsberg 2014-08-01 14:11:04 UTC
Nir, do you have any guess how we got ourselves a cycle like that?

Comment 4 Nir Soffer 2014-08-01 15:37:15 UTC
See bug 1124498

Comment 5 Raz Tamir 2014-09-03 14:18:40 UTC
Verified on vdsm-4.16.2-1.gite8cba75.el6.x86_64

followed the steps to reproduce

Comment 6 Sandro Bonazzola 2014-10-17 12:31:39 UTC
oVirt 3.5 has been released and should include the fix for this issue.