Bug 1125335

Summary: Review Request: perl-TestML - Generic software Testing Meta Language
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: David Dick <ddick>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ddick, package-review
Target Milestone: ---Flags: ddick: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-TestML-0.42-1.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-07 12:47:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 1124847, 1125222    
Bug Blocks: 1125360    

Description Petr Pisar 2014-07-31 15:15:29 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-TestML/perl-TestML.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-TestML/perl-TestML-0.37-1.fc22.src.rpm
Description:
TestML <http://www.testml.org/> is a generic, programming language agnostic,
meta language for writing unit tests. The idea is that you can use the same
test files in multiple implementations of a given programming idea. Then you
can be more certain that your application written in, say, Python matches your
Perl implementation.

In a nutshell you write a bunch of data tests that have inputs and expected
results. Using a simple syntax, you specify what functions the data must pass
through to produce the expected results. You use a bridge class to write the
data functions that pass the data through your application.

In Perl 5, TestML module is the evolution of the Test::Base module. It has
a superset of Test:Base's goals. The data markup syntax is currently exactly
the same as Test::Base.

Fedora Account System Username: ppisar

Comment 1 David Dick 2014-08-07 09:41:38 UTC
Ingy has released 5 new versions in the last four days.  I'll review this version, but would be happy if you want to upgrade to the most recent version.

Comment 2 David Dick 2014-08-07 10:32:53 UTC
License is good.

Package builds at http://koji.fedoraproject.org/koji/taskinfo?taskID=7253979

rpmlint reports incorrect spelling mistakes and one acceptable one.

recommend replacing "superset" with "super set" or "super-set" in %description

Build and RunTime requires are correct.

There are no additional Build or RunTime requires in 0.42 (latest version) and no license differences either.

Package APPROVED.

Comment 3 Petr Pisar 2014-08-07 11:12:01 UTC
New Package SCM Request
=======================
Package Name: perl-TestML
Short Description: Generic software Testing Meta Language
Upstream URL: http://search.cpan.org/dist/TestML/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2014-08-07 12:20:46 UTC
Git done (by process-git-requests).

Comment 5 Petr Pisar 2014-08-07 12:29:02 UTC
Package Change Request
======================
Package Name: perl-TestML
Owners:
Branches: 
InitialCC: perl-sig

You script still forgets InitialCC. Fix it.

Comment 6 Petr Pisar 2014-08-07 12:47:59 UTC
Thank you for the review and the repository.

I suppressed the false rpmlint warnings and upgraded the package to 0.42.

Comment 7 Gwyn Ciesla 2014-08-07 14:24:32 UTC
Complete.

I've requested that it be fixed, I don't have the requisite pkgdb2
knowledge.