Bug 1126204

Summary: placeholders of child commands aren't cleared when failing during the execution
Product: Red Hat Enterprise Virtualization Manager Reporter: Liron Aravot <laravot>
Component: ovirt-engineAssignee: Ravi Nori <rnori>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: acanan, amureini, ecohen, eedri, gklein, iheim, laravot, lpeer, ofrenkel, ogofen, oourfali, rbalakri, Rhev-m-bugs, rnori, scohen, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: ovirt-3.5.0_rc1.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1126205 (view as bug list) Environment:
Last Closed: 2015-02-17 17:13:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1142923, 1156165    
Attachments:
Description Flags
logs + table data none

Description Liron Aravot 2014-08-03 14:39:19 UTC
Created attachment 923633 [details]
logs + table data

Description of problem:
Task placeholders aren't being cleared on failure to execute a command

How reproducible:
Always

Steps to Reproduce:
1. Execute a command which creates async task placeholders for it's child commands  when more than one child commands is supposed to be executed (for example - AddVmTemplate for vm with more than one disk)
2. Fail during the execution of one of it's child commands 

Actual results:
The placeholder for the failed child command will be cleared, the other child command placeholders aren't cleared.

Expected results:
All placeholders should be cleared

Comment 1 Ravi Nori 2014-08-04 17:12:55 UTC
*** Bug 1126205 has been marked as a duplicate of this bug. ***

Comment 2 Jiri Belka 2014-09-05 14:15:30 UTC
please provide exact steps for verification, thank you

Comment 3 Ravi Nori 2014-09-05 14:19:29 UTC
I manually threw an exception in the execution of one of the child commands. Adding need info on Liron Aravot for ideas how to test this. I would consider this a code change.

Comment 4 Liron Aravot 2014-09-10 08:17:58 UTC
We can manually cause to exception in the execute phase, for example, move image folder in the storage manually which will cause to an error when trying to copy it.

Comment 5 Jiri Belka 2014-09-11 10:01:14 UTC
ok, rhevm-backend-3.5.0-0.11.beta.el6ev.noarch

tested while creating a vm from template and the template's disk dir on storage domain was renamed, no async task after failure.

Comment 6 Eyal Edri 2015-02-17 17:13:46 UTC
rhev 3.5.0 was released. closing.