Bug 1126293

Summary: Add Users dialog has too much padding below the users grid
Product: [oVirt] ovirt-engine Reporter: Kobi Hakimi <khakimi>
Component: Frontend.WebAdminAssignee: Greg Sheremeta <gshereme>
Status: CLOSED CURRENTRELEASE QA Contact: samuel macko <smacko>
Severity: low Docs Contact:
Priority: low    
Version: 3.5.0CC: bugs, gshereme, lsurette, mgoldboi, oourfali, rbalakri, Rhev-m-bugs, rhv-bugzilla-bot, srevivo, ykaul
Target Milestone: ovirt-4.2.0Keywords: FutureFeature, Improvement
Target Release: ---Flags: rule-engine: ovirt-4.2?
pstehlik: testing_plan_complete-
rule-engine: planning_ack?
rule-engine: devel_ack+
pstehlik: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-20 11:35:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The list should stretch to all page
none
looks good in 4.2 none

Description Kobi Hakimi 2014-08-04 06:00:06 UTC
Created attachment 923776 [details]
The list should stretch to all page

Description of problem:
[RHEVM GUI] in 'Add Users and Groups' dialog The list should stretch to all page.

Version-Release number of selected component (if applicable):
 Red Hat Enterprise Virtualization Manager Version: 3.4.0-0.21.el6ev 
 oVirt Engine Version: 3.5.0-0.0.master.20140715172116.git4687dc1.el6 

How reproducible:
Always

Steps to Reproduce:
Go to Users tab and click on Add.

Actual results:
The 'Add Users and Groups' Dialog opened with unused space in the bottom of the list.

Expected results:
To use all the dialog space to present the users and groups list.

Additional info:
see attached snapshot

Comment 1 Einav Cohen 2014-08-15 15:30:20 UTC
this dialog is being used also for adding permissions, I am guessing that the leftover space at the bottom is the one used to display the Role drop-down in case of permissions granting. 

we have a similar issue in the confirmation dialog (see bug 966427), not sure if there is a quick and easy solution for this issue.

Comment 2 Einav Cohen 2014-08-15 15:30:58 UTC
[moving to 'NEW', even though there is a patch, since the patch doesn't seem to solve the problem properly]

Comment 3 Einav Cohen 2015-04-20 21:55:19 UTC
we will look into that when migrating dialogs to PatternFly.

Comment 4 Red Hat Bugzilla Rules Engine 2016-03-06 13:26:51 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 5 Red Hat Bugzilla Rules Engine 2017-11-30 17:41:02 UTC
This request has been proposed for two releases. This is invalid flag usage. The ovirt-future release flag has been cleared. If you wish to change the release flag, you must clear one release flag and then set the other release flag to ?.

Comment 6 Greg Sheremeta 2017-11-30 17:41:37 UTC
Created attachment 1361085 [details]
looks good in 4.2

Comment 7 RHV bug bot 2017-12-06 16:02:37 UTC
Where is the relevant tracker for this bug? I see one which is abandoned?
On which engine version was this fixed?

Comment 8 RHV bug bot 2017-12-06 16:17:23 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[No relevant external trackers attached]

For more info please contact: infra

Comment 9 Greg Sheremeta 2017-12-06 18:08:44 UTC
It was fixed in the 4.2 redesign, but I have no idea which specific patch.

Comment 10 samuel macko 2017-12-19 14:03:23 UTC
Verified in RHEVM 4.2.0.2-0.1.el7

Verified by following the reproducer.

Comment 11 Sandro Bonazzola 2017-12-20 11:35:56 UTC
This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017.

Since the problem described in this bug report should be
resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.