Bug 1126388
| Summary: | "rhc server list" show that an unexpected server is in use if user change libra_server manually. | |||
|---|---|---|---|---|
| Product: | OpenShift Online | Reporter: | Johnny Liu <jialiu> | |
| Component: | oc | Assignee: | Fabiano Franz <ffranz> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 2.x | CC: | bleanhar, jokerman, mmccomas, xiuwang, xtian | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | Doc Type: | Bug Fix | ||
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1130347 (view as bug list) | Environment: | ||
| Last Closed: | 2014-10-10 00:50:15 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1128646, 1130347 | |||
|
Description
Johnny Liu
2014-08-04 10:15:12 UTC
Commit pushed to master at https://github.com/openshift/rhc https://github.com/openshift/rhc/commit/c4222ca7261183cd9063487484a375c98038bcd5 Bug 1126388 - must properly handle express.conf server missing on servers.yml Checked rhc build from devenv_5043 1.Change libra_server in .openshift/express.conf manually,list server. Could see the friendly message, and the new adding server is in use. Check server.yml,don't server the new adding server info yet. # rhc server list The server 'stg.openshift.redhat.com' is not configured. Please run 'rhc setup'. Server 'online' ------------ Hostname: openshift.redhat.com Login: XXXXXXXXXXXXXXX Use Auth Tokens: false Insecure: false Server 'stg' (in use) --------------------- Hostname: stg.openshift.redhat.com 2.Run setup as the promption, still show "The server 'stg.openshift.redhat.com' is not configured. Please run 'rhc setup'.This will make user confused.So assigen this bug back. Another scenario: Setup or add the first server, also show The server 'openshift.redhat.com' is not configured. Please run 'rhc setup'.Rhc always check the express.conf firstly. # rhc setup -d The server 'openshift.redhat.com' is not configured. Please run 'rhc setup'. DEBUG: Using config file /root/.openshift/express.conf DEBUG: Running greeting_stage OpenShift Client Tools (RHC) Setup Wizard # rhc server add openshift.redhat.com -d The server 'openshift.redhat.com' is not configured. Please run 'rhc setup'. DEBUG: Using config file /root/.openshift/express.conf Commit pushed to master at https://github.com/openshift/rhc https://github.com/openshift/rhc/commit/166f00dfd2ab0aa4a82bc5b37e1cf9add4464756 Bug 1126388 - only warns if unconfigured server comes from conf files The behavior is still the same but we decided to remove the warning message. Will merge in https://github.com/openshift/rhc/pull/639 Commit pushed to master at https://github.com/openshift/rhc https://github.com/openshift/rhc/commit/66fabd9b24b27df7893440150a4ea780c1241faa Bug 1126388 - removed warning message Check rhc-1.29.2. Failed for below scenarios.It's better to fix them from my opinion. Scenario one: 1.Change libra_server in .openshift/express.conf manually,list server. Could see the friendly message # rhc server list The server 'openshift.redhat.com' is not configured. Please run 'rhc setup'. Server 'int' ------------ Hostname: int.openshift.redhat.com Login: XXXXXXXXXXXXXXX Use Auth Tokens: false Insecure: false Server 'online' (in use) --------------------- Hostname: openshift.redhat.com 2.Then run 'rhc setup' according to the message.Still prompt the warning.Don't think it's a good way. # rhc setup The server 'openshift.redhat.com' is not configured. Please run 'rhc setup'. OpenShift Client Tools (RHC) Setup Wizard Scenario two: 1.Change libra_server in .openshift/express.conf manually 2.Before run 'setup' for the non-configured server,add the third server and don't change default server. Do some operation,could see the warning gone,even though I don't run setup for the manaully adding server. # rhc server add int.openshift.redhat.com -l <user> The server 'openshift.redhat.com' is not configured. Please run 'rhc setup'. Using <user> to login to int.openshift.redhat.com Password: ****** [root@wangxiuj .openshift]# # rhc account Login to openshift.redhat.com: XXXXXXX Password: ****** The warning message was removed, everything else stays the same. Fixed in https://github.com/openshift/rhc/pull/642 The warning message will not be displayed anymore, however when listing servers and a given server is only present in express.conf it will be displayed in yellow with a 'not configured' instead of 'in use' message in the servers list. Commit pushed to master at https://github.com/openshift/rhc https://github.com/openshift/rhc/commit/c434a88df2f5a380d54fcfa7906dfdbdbab943c1 Bug 1126388 - when displaying servers will warn if a given server is not yet configured Verified with rhc-1.29.6 build from devenv_5089 A given server is only present in express.conf it will be displayed in yellow with a 'not configured' instead of 'in use' message in the servers list # rhc server list Server 'int' (not configured, run 'rhc setup') ---------------------------------------------- Hostname: int.openshift.redhat.com Server 'stg' ------------ Hostname: stg.openshift.redhat.com Login: xiuwang Use Auth Tokens: true Insecure: false You have 2 servers configured. Use 'rhc server use <hostname|nickname>' to switch between them. |