Bug 1126556

Summary: [ovirt-branding] increment branding interface number
Product: [Retired] oVirt Reporter: Alexander Wels <awels>
Component: ovirt-engine-webadminAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.5CC: awels, ecohen, gklein, iheim, mgoldboi, rbalakri, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ux
Fixed In Version: ovirt-3.5.0_rc1.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-17 12:21:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alexander Wels 2014-08-04 19:00:47 UTC
Description of problem:
The current version of the branding interface is at 1, with the introduction of patternfly we cannot maintain compatibility with version 1. We need to increase the interface version to 2.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Jiri Belka 2014-09-05 12:15:29 UTC
What is supposed to be verified here?

Comment 2 Alexander Wels 2014-09-05 12:30:30 UTC
You should be able to verify the following:

1. Verify that the version property in /etc/ovirt-engine/branding/00-ovirt.brand/ branding.properties is set to 2.
2. If you install a branding package (for instance the RHEV one) and the version is NOT 2 in its associated branding.properties, it won't load. In fact there should be a warning in your log that it found a branding package but that it was incompatible.

Comment 3 Jiri Belka 2014-09-08 09:15:28 UTC
ok

[root@jb-rhevm35 ~]# grep 2 /etc/ovirt-engine/branding/00-ovirt.brand/branding.properties 
version=2

Comment 4 Sandro Bonazzola 2014-10-17 12:21:13 UTC
oVirt 3.5 has been released and should include the fix for this issue.