Bug 1126937

Created from redmine issue http://projects.theforeman.org/issues/6861

Upstream bug assigned to stbenjam

This is needed in order to make Host Group provisioning fully work.

Upstream commit:
7d5aaa825a87d308650b6f3ebdea6bbef4f86dce

Moving to POST since upstream bug http://projects.theforeman.org/issues/6861 has been closed
-------------
Anonymous
Applied in changeset commit:7d5aaa825a87d308650b6f3ebdea6bbef4f86dce.

Marking this verified since group provisioning appears to be ok.

Satellite-6.0.4-RHEL-6-20140813.2

Confirmed that it works with 6.0.7, this issue can be closed.

1) created a host_group
2)associate katello kickstart default to a host-group
3) Deploy default PXE files
4) check the file on sat6  /var/lib/tftpboot/pxelinux.cfg/default

Rendering fails:

http://dhcp201-167.englab.pnq.redhat.com/unattended/template/Katello%20Kickstart%20Default/rhel66_grp

Get the below message when accessing the URL or provisioning.

There was an error rendering the Unnamed template: undefined method 'mac' for Hostgroup::Jail (Hostgroup)

TESTED with sat6.1 Beta snap6 compose2.

this bug depends on bug 1220728 which is marked for 6.2.0 and this for 6.1.1.

moving to 6.2

The @provision_type works fine since 6.0.5 or so, we use it on a daily basis for at least 6 months.

The failure on the hostgroup jail that is cannot find the .mac is correct. The accessing of the .mac shall be done only when the @provision_type != hostgroup.

That means that this issue can be closed and then use the "@provision_type != hostgroup" feature to fix the BZ1220728

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592

Accidentally closed with 6.1.1 errata

FailedQA.

@satellite-6.2.0-14.2.el7sat.noarch

the behavior is the same as comment #16 had reported:

2016-06-06 06:25:02 [app] [I] Started GET "/unattended/template/Satellite%20Kickstart%20Default/My%20Hostgroup" for <CLIENT_IP> at 2016-06-06 06:25:02 -0400
2016-06-06 06:25:02 [app] [I] Processing by UnattendedController#hostgroup_template as HTML
2016-06-06 06:25:02 [app] [I]   Parameters: {"id"=>"Satellite Kickstart Default", "hostgroup"=>"My Hostgroup"}
2016-06-06 06:25:02 [app] [I]   Rendered inline template (71.7ms)
2016-06-06 06:25:02 [app] [W] There was an error rendering the Unnamed template: 
 | ActionView::Template::Error: undefined method 'mac' for Hostgroup::Jail (Hostgroup)
 | /opt/theforeman/tfm/root/usr/share/gems/gems/safemode-1.2.3/lib/safemode/jail.rb:17:in `method_missing'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/safemode-1.2.3/lib/safemode.rb:89:in `bind'

Upstream bug component is Provisioning Templates

I'm just going to close this.  This variable was added over 2 years ago and working just fine since then - but QE wants to verify with the shipped Satellite templates which are always broken with HG provisioning due to other issues.  That's how long hostgroup provisioning has been broken in one fashion or another. 

If you really wanted to verify this, you could create a 1-line template

<%= @provisioning_type %>

and preview the template in a host group or host provsioning scenario, but imho it's a waste of QE's time.  

If users are using hostgroup provisioning, they need to write their own templates, and generally people should be directed to use PXEless discovery anyway.

Then it's OK to close this.
But I need to move my failedqa to more proper bug then.

Moving to > BZ 1126087 
undefined method 'certname' for Hostgroup::Jail (customer reported)
undefined method 'mac' for Hostgroup::Jail (me reported)

We can leave the bug open but not sure that we'll fix it - when I discussed with others on IRC, we agreed to keep HG provisioning as is and only fix regressions. Those errors aren't regressions since they never worked.  Users need to create their own basic templates for use with HG provisioning because it's such a limited feature.

The two errors -- certname is for puppet.conf and mac is from the networking snippet -- can't really work with HG provisioning anyway, you need a real host.