Bug 1127453

Summary: RFE: network: support net-update for <domain name=XXX/>
Product: [Community] Virtualization Tools Reporter: Rich Megginson <rmeggins>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED DEFERRED QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: crobinso, dyuan, yalzhang
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-03 17:01:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Rich Megginson 2014-08-06 21:32:56 UTC
Description of problem:

Trying to use virsh net-update to add a domain name

$ sudo virsh net-update default add domain "<domain name='test'/>"
--live --config
error: this function is not supported by the connection driver: can't
update 'domain' section of network 'default'

Version-Release number of selected component (if applicable):

libvirt-1.1.3.5-2.fc20.x86_64

How reproducible:


Steps to Reproduce:
1. sudo virsh net-update default add domain "<domain name='test'/>"
--live --config
2.
3.

Actual results:
error: this function is not supported by the connection driver: can't
update 'domain' section of network 'default'

Expected results:
New virtual machines created with network 'default' should use the specified network domain name 'test'
Existing running virtual machines will use the old name before the update

Additional info:
> is it possible to add a domain using net-update?

No, not currently. It would be fairly simple to add support for
re-starting the network's dnsmasq instance with the new domain in the
commandline arguments, but that wouldn't address the existing guests
that have already received the domain name in their DHCP responses -
they would continue appending the old domain name to any DNS queries
until their DHCP lease expires and they have to renew (assuming that the
guest's lease renewal code is intelligent enough to notice that the
domain has changed).

If the above is acceptable, and you're interesting in adding support for
that much of the functionality, the function to change is
virNetworkDefUpdateDomain() (higher level functions are already setup to
handle restarting dnsmasq). You could follow the examples of other
virNetworkDefUpdate*() functions in the same file.

Comment 1 Daniel Berrangé 2020-11-03 17:01:02 UTC
Thank you for reporting this issue to the libvirt project. Unfortunately we have been unable to resolve this issue due to insufficient maintainer capacity and it will now be closed. This is not a reflection on the possible validity of the issue, merely the lack of resources to investigate and address it, for which we apologise. If you none the less feel the issue is still important, you may choose to report it again at the new project issue tracker https://gitlab.com/libvirt/libvirt/-/issues The project also welcomes contribution from anyone who believes they can provide a solution.