Bug 1127916

Summary:	fedora-review doesn't recognize %license
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	fedora-review	Assignee:	Stanislav Ochotnicky <sochotni>
Status:	CLOSED UPSTREAM	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	20	CC:	fedora, leamas.alec, petersen, pingou, projects.rg, sochotni
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-02-26 17:36:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry James 2014-08-07 20:18:04 UTC

Description of problem:
When running fedora-review on a package that uses the new %license tag, fedora-review complains:

- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find LICENSE in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

And also:

[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/licenses
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/licenses

All of these message disappear if the license file is moved to %doc.

Version-Release number of selected component (if applicable):
fedora-review-0.5.1-2.fc20.noarch

How reproducible:
Always

Steps to Reproduce:
1. Review a package that uses %license
2.
3.

Actual results:
The incorrect messages shown above.

Expected results:
Golden silence.

Additional info:

Comment 1 Jens Petersen 2014-11-14 00:46:16 UTC

Increasing severity in view of https://fedorahosted.org/fpc/ticket/411

Comment 2 Pierre-YvesChibon 2014-11-14 06:45:50 UTC

You are right, although, saw the last comment on that ticket ?

Comment 3 Jens Petersen 2014-11-14 08:35:45 UTC

Right I did - it is approved but seems FPC is not always so quick to update the wiki.

Comment 4 Raphael Groner 2015-02-26 17:36:05 UTC

This is fixed in the devel branch at fedorahosted.

Alternatively, someone could use the following line to prevent an error:

%{!?_licensedir:%global license %%doc}