Bug 1128100

The tests are failing in at least F20 and Rawhide:

======================================================================
FAIL: test_api (tests.test_public_api.APITest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/makerpm/rpmbuild/BUILD/Markups-0.5.0/tests/test_public_api.py", line 18, in test_api
    self.assertTrue(isinstance(markup, markups.MarkdownMarkup))
AssertionError: False is not true

Remove the version constraints from the BRs. They are fulfilled in every release of Fedora.

Use %global instead of %define.

Use a wildcard for the Python version for the egg-info in the files section, otherwise you'd have to adapt it on branches and new releases!

Please delete the egg-info directory in the prep section. It should only be included if it's generated by the build script.

Thanks for looking into this. I think I fixed most of the issues.

SPEC: https://comzeradd.fedorapeople.org/specs/python-markups.spec
SRPM: https://comzeradd.fedorapeople.org/srpms/python-markups-0.5.0-2.fc20.src.rpm

I packaged it month ago. 

IMO this package should be named python-Markups.

I just followed what seems to be the current trend at python packages, to be all lowercase. For instance Markdown is packaged as python-markdown.

- You can drop Requires: python, it's not necessary.

- Documentation must be included in Python 3 subpackage as well.

Good catch

SPEC: https://comzeradd.fedorapeople.org/specs/python-markups.spec
SRPMS: https://comzeradd.fedorapeople.org/srpms/python-markups-0.5.0-3.fc20.src.rpm

Thank you, Mayorga!

You didn't say which branches you want to create, but just in case you don't know: F20 has no python3-textile.

I was wondering whether the description is accurate and not misleading, in regards to "(these two are supported by default)."

However, APPROVED!

I'm sorry, you all didn't realize the essential issues:

1. %global with_python3 1
%global srcname Markups

Name:           python-markups
Version:        0.5.0
Release:        3%{?dist}
Summary:        A wrapper around various text markups

License:        BSD
URL:            https://pypi.python.org/pypi/Markups
Source0:        https://pypi.python.org/packages/source/M/%{srcname}/%{srcname}-%{version}.tar.gz

BuildArch:      noarch
BuildRequires:  python2-devel
BuildRequires:  python-setuptools
BuildRequires:  python-markdown
BuildRequires:  python-docutils
BuildRequires:  python-textile
Requires:       python-markdown
Requires:       python-docutils
Requires:       python-textile
%if 0%{?with_python3}
BuildRequires:  python3-devel
BuildRequires:  python3-setuptools
BuildRequires:  python3-markdown
BuildRequires:  python3-docutils
BuildRequires:  python3-textile
Requires:       python3-markdown
Requires:       python3-docutils
Requires:       python3-textile
%endif

Yeah yeah, when you enable python3 build the python-markup will have python3 dependencies in itself whereas python3-markup has no python3 deps.

Please, move the %if 0%{?with_python3}...%endif to underneath the python3 %package.

2. rm -rf %{buildroot}/%{python3_sitelib}/*.egg-info

Please, I don't know what you are doing here, doing this will cause FTBFS of other packages. Volker is right, he told you to

(In reply to Volker Fröhlich from comment #2)
> Please delete the egg-info directory in the prep section. 

Which means the python eggs shipped in the tarball should be deleted _before_ %build, not to let you delete those generated by %build.

s/to underneath/beneath/, sorry for the typo as I'm on iPad.

I have package several python packages before, but none so far with python3 subpackage. Can you elaborate on the dependency thing?

> Yeah yeah, when you enable python3 build the python-markup will have python3
> dependencies in itself whereas python3-markup has no python3 deps.
> 
> Please, move the %if 0%{?with_python3}...%endif to underneath the python3
> %package.

Why is that? I followed examples from other packages currently at Fedora that have the python3 dependencies along with python2 ones. For instance:
http://pkgs.fedoraproject.org/cgit/python-markdown.git/tree/python-markdown.spec
http://pkgs.fedoraproject.org/cgit/python-docutils.git/tree/python-docutils.spec

Thanks

(In reply to Nikos Roussos from comment #11)
> http://pkgs.fedoraproject.org/cgit/python-markdown.git/tree/python-markdown.
> spec
> http://pkgs.fedoraproject.org/cgit/python-docutils.git/tree/python-docutils.
> spec

These 2 are correct, because they only put BuildRequires in the conditional blocks, not like this one from you, putting BuildRequires and Requires to wrong place exactly.

Your initial spec will give python-markups dependencies hereunder:

Requires:       python3-markdown
Requires:       python3-docutils
Requires:       python3-textile

And python2 packages shouldn't pull in any python3 deps, I think you should be able to understand this.

Thanks for the clarification. I think I get it now.

SPEC: https://comzeradd.fedorapeople.org/specs/python-markups.spec
SRPM: https://comzeradd.fedorapeople.org/srpms/python-markups-0.5.0-4.fc20.src.rpm

Ok so the issue I found solved.

Hint: rm -rf %{srcname}-%{version}/Markups.egg-info is redundant, just rm -rf Markups.egg-info is enough I think(unless you really prefer old schools.)

As Volker hasn't posted any full review text, I won't set + here, Volker if you think this is OK, then let it go.

I will mark my bug as duplicate of this one, although I'm the first.

*** Bug 1119007 has been marked as a duplicate of this bug. ***

Thanks, I somehow missed this bug.

@Volker could you finalize the review process?

Sorry, I'm constantly overworked.

This has already been packaged in the meantime on #1169493

*** This bug has been marked as a duplicate of bug 1169493 ***