Bug 1128202

Summary: /usr/lib/systemd/fedora-readonly has poor indenting
Product: [Fedora] Fedora Reporter: John Florian <john>
Component: initscriptsAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: jonathan, lnykryn, vpavlin, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-08 14:59:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Attachments:
Description Flags
indentation patch none

Description John Florian 2014-08-08 14:48:43 UTC
Created attachment 925193 [details]
indentation patch

Description of problem:
I'm unaware of any formal documentation for the stateless support in Fedora and thus must resort to reading the shell script to understand the behavior and how I can use it.  Unfortunately this task is made difficult by the poor indenting within /usr/lib/systemd/fedora-readonly.

I'm attaching a patch here that only alters the leading whitespace in this script so that indentation is correct and consistent throughout.  I hope this can be applied so that future readers may also benefit.  This should apply cleanly initscripts-9.51.

Comment 1 Lukáš Nykrýn 2014-08-08 14:59:57 UTC
Yes I agree that indentation in initscripts is really terrible. I thought fixing it in the past, but the problem is that it will make work with git history (git blame) more complicated.

So I am really sorry but I will not apply your patch.

And by the way I hope that we will drop this script in near future and use http://0pointer.de/blog/projects/stateless.html