Bug 1128335
Summary: | Review Request: libdom - C implementation of the W3C DOM | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | hdegoede, package-review |
Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | libdom-0.1.0-1.fc22 libdom-0.1.0-1.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-08-13 02:11:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Christopher Meng
2014-08-09 07:08:54 UTC
Full review done: Good: ===== - rpmlint checks return: libdom-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 1 warnings. -This is just rpmlint showing a new level of mindlessness even for rpmlint, can be safely ignored - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on F-21 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r and isa Needs work: ======== - Nothing APPROVED. Thanks! I will reply your ticket later, I have some situations here. New Package SCM Request ======================= Package Name: libdom Short Description: C implementation of the W3C DOM Upstream URL: http://www.netsurf-browser.org/projects/libdom/ Owners: cicku Branches: f19 f20 f21 epel7 el6 Git done (by process-git-requests). |