Bug 1128356
| Summary: | Review Request: minipro - Utility for MiniPro TL866A/TL866/CS programmer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Mihkel Vain <mihkel.vain> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | lkundrak, lrintel, mihkel.vain, package-review |
| Target Milestone: | --- | Flags: | mihkel.vain:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-01 10:13:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lubomir Rintel
2014-08-09 11:17:09 UTC
%config(noreplace) %{_sysconfdir}/bash_completion.d
You shouldn't set this as %config.
(In reply to Christopher Meng from comment #1) > %config(noreplace) %{_sysconfdir}/bash_completion.d > > You shouldn't set this as %config. But rpmlint behaves like it doesn't love me anymore then :( SPEC: http://v3.sk/~lkundrak/SPECS/minipro.spec SRPM: http://v3.sk/~lkundrak/SRPMS/minipro-0-2.20140624gite521a63.fc20.src.rpm SPEC: http://v3.sk/~lkundrak/SPECS/minipro.spec SRPM: http://v3.sk/~lkundrak/SRPMS/minipro-0-2.20140902git6f36b9e.fc20.src.rpm Ok. Few comments at first: rpmlint *.rpm minipro.src: W: name-repeated-in-summary C MiniPro minipro.x86_64: W: name-repeated-in-summary C MiniPro minipro.x86_64: W: only-non-binary-in-usr-lib minipro.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/minipro minipro.x86_64: E: sourced-script-with-shebang /etc/bash_completion.d/minipro /bin/bash minipro.x86_64: W: no-manual-page-for-binary minipro-query-db minipro.x86_64: W: no-manual-page-for-binary miniprohex minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.c minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.h 3 packages and 0 specfiles checked; 3 errors, 6 warnings. -------------------------------------------- minipro.src: W: name-repeated-in-summary C MiniPro minipro.x86_64: W: name-repeated-in-summary C MiniPro To me Summary looks fine. I think we can ignore those. minipro.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/minipro minipro.x86_64: E: sourced-script-with-shebang /etc/bash_completion.d/minipro /bin/bash I think you should remove the shebang minipro.x86_64: W: no-manual-page-for-binary minipro-query-db minipro.x86_64: W: no-manual-page-for-binary miniprohex minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.c minipro-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/minipro-6f36b9eff8b82d5aa89f2fb07b0940383327a896/easyconfig.h Manual pages are a SHOULD according to this https://fedoraproject.org/wiki/Packaging:ReviewGuidelines But not a blocker. Also you should notify upstream about fsf address. So. If you remove shebang I think we are good to go. SPEC: http://v3.sk/~lkundrak/SPECS/minipro.spec SRPM: http://v3.sk/~lkundrak/SRPMS/minipro-0-3.20140902git6f36b9e.fc20.src.rpm CHECKSUM(SHA256) this package : 28190b0b1c5f7ffdc575ddd6736db519fd79a1f16f01412ebc8e3c2033fd6d88 CHECKSUM(SHA256) upstream package : 28190b0b1c5f7ffdc575ddd6736db519fd79a1f16f01412ebc8e3c2033fd6d88 Checksum is good. LICENSE is included in source tarball and is acceptable for Fedora. Although rpmlint produces 5 warnings and mentions about wrong FSF address in two source files (easyconfig.c and easyconfig.h) I consider them a non-blockers, but you should notify upstream about wrong FSF address. APPROVED New Package SCM Request ======================= Package Name: minipro Short Description: Utility for MiniPro TL866A/TL866/CS programmer Upstream URL: https://github.com/vdudouyt/minipro Owners: lkundrak Branches: f20 f21 el6 epel7 Git done (by process-git-requests). Imported and built. Thank you! |