Bug 1128366
| Summary: | Review Request: lis - A library for solving linear equations and eigenvalue problems | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian "der-flo" Lehner <dev> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lis-1.4.57-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-08-28 15:28:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Florian "der-flo" Lehner
2014-08-09 15:05:28 UTC
As you've taken the package, doing some cleanup is needed. Please cleanup those obsoleted stuffs in the SPEC. Spec URL: https://flo.fedorapeople.org/lis.spec SRPM URL: https://flo.fedorapeople.org/lis-1.4.53-2.fc20.src.rpm koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7269578 * Sun Aug 10 2014 Florian Lehner <dev> - 1.4.53-2 - Remove defattr at the beginning of the files-section - Use default buildroot instead of making its own - Remove unnecessary clean-section - Use pushd and popd instead of cd If I missed something, please point me at it. 1. 1.4.55(japanese version page) is out.
2. Can't "make check" work?
3. I'm not sure if --enable-longlong is needed on 64 bits arch, you'd better drop an email to the upstream.
4. WRONG:
%package doc
Summary: Developer documentation for lis
Group: Documentation
Requires: %{name}%{?_isa} = %{version}-%{release}
%description doc
Lis, a Library of Iterative Solvers for linear systems, is a scalable parallel
library for solving systems of linear equations and standard eigenvalue
problems with real sparse matrices using iterative methods.
This package contains the developer documentation for lis.
i. No BuildArch: noarch
ii. Requires: %{name}%{?_isa} = %{version}-%{release}
When you fix i, drop the %_isa macro.
(In reply to Christopher Meng from comment #3) > 2. Can't "make check" work? Unfortunately, it is stated: *** No rule to make target 'check' > 3. I'm not sure if --enable-longlong is needed on 64 bits arch, you'd better > drop an email to the upstream. It's necessary for cross compiling Spec URL: https://flo.fedorapeople.org/lis.spec SRPM URL: https://flo.fedorapeople.org/lis-1.4.55-1.fc20.src.rpm koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7274631 1. Drop all "Group" tags in the SPEC. 2. lis.i686: W: spurious-executable-perm /usr/share/doc/lis/AUTHORS lis.i686: W: spurious-executable-perm /usr/share/doc/lis/COPYING Others are fine. Fix 2 above and build in koji then push to f20+ IMO is the best scheme. Here is the update: Spec URL: https://flo.fedorapeople.org/lis.spec SRPM URL: https://flo.fedorapeople.org/lis-1.4.56-1.fc20.src.rpm koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7283428 Fine now. Please build and push. I won't set the review flag as this package is already in the repo and not deprecated. When you push updates to stable Fedora branches, mention this bug in Bugs section. lis-1.4.56-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lis-1.4.56-1.fc20 Package lis-1.4.56-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lis-1.4.56-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-9451/lis-1.4.56-1.fc20 then log in and leave karma (feedback). lis-1.4.57-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/lis-1.4.57-1.fc20 lis-1.4.57-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |