Bug 1128378

So fast ;) I talked to some openSUSE guys last week about this package.

As I want to notify here, upstream has adopted a manpage. So I hope you can package a snapshot here.

You are building it without honoring the flags defined already.

See my PR also: https://github.com/Xfennec/cv/pull/29

hi!

Thanks for assigning!

I know there is a patch merged already for a manpage. But it's not part of the current stable version. I am quite sure there will be a new release containing this manpage.

I will wait and see what happens upstream with your PR.

Instead of overriding the flags I appended the fedora-default flags. So there is a new version:

Spec URL: https://flo.fedorapeople.org/cv.spec
SRPM URL: https://flo.fedorapeople.org/cv-0.4.1-2.fc20.src.rpm
koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7269524

Some remarks:

1. I do not see any reason why this package should be built hardened.
=> Remove "%global _hardened_build 1"

2. Passing LDFLAGS is not required.
=> Remove LDFLAGS+="%{?__global_ldflags}" 

3.  Package does not honor CFLAGS:

gcc -g -Wall -D_FILE_OFFSET_BITS=64 -c cv.c
gcc -g -Wall -D_FILE_OFFSET_BITS=64 -c sizes.c
gcc -g -Wall -D_FILE_OFFSET_BITS=64 -c hlist.c
gcc -Wall cv.o sizes.o hlist.o -o cv -lncurses -lm  

This package uses simple and naive Makefile, so you need to override CFLAGS from the environment or make's command-line.

(In reply to Ralf Corsepius from comment #4)

> 2. Passing LDFLAGS is not required.
> => Remove LDFLAGS+="%{?__global_ldflags}" 

Ralf are you serious?!?  Why are those LDFLAGS setup by %configure or %cmake macros then, if they are not needed?!?

Passing those LDFLAGS is important to have at least partial RELRO applied onto the linked binaries:

$ rpm --eval %__global_ldflags
-Wl,-z,relro  ---> results in partial relro binaries

and when applying hardening flags:

$ rpm -D'_hardened_build 1' --eval %__global_ldflags
-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld  ---> will result in in PIE / PIC and fully relro binaries.

So please explain why LDFLAGS are not required and should be removed!?!

(In reply to Ralf Corsepius from comment #4)
> 2. Passing LDFLAGS is not required.
> => Remove LDFLAGS+="%{?__global_ldflags}" 

No. It's linked against ncurses. It's a MUST.

(In reply to Florian "der-flo" Lehner from comment #3)
> Instead of overriding the flags I appended the fedora-default flags.

Obviously You don't know how to use automake IMO. You are still overriding the flags.

If you don't use my patch, simply hack from command line won't work.

ok - here we are again.

I hope I have understood you and implemented the points correctly.

Spec URL: https://flo.fedorapeople.org/cv.spec
SRPM URL: https://flo.fedorapeople.org/cv-0.4.1-3.fc20.src.rpm
koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7270227

1. Please, unset %global _hardened_build 1, I don't know why you prefer adding this to all packages.

2. LDFLAGS still not set:

cc -Wall cv.o sizes.o hlist.o -o cv -lncurses -lm

In your spec:

LDFLAGS="%{?__global_ldflags}"	\

Ooops, upstream uses LFLAGS XD.

3. mkdir -p %{buildroot}%{_bindir}
install -pm 0755 %{name} %{buildroot}%{_bindir}/%{name}

If you read the makefile carefully, you can try "%make_install PREFIX=%{buildroot}%{_prefix}". In the next version, use "%make_install PREFIX=%{_prefix}".

Long working days are long. So here we go:

I've done what you said.

(In reply to Christopher Meng from comment #9)
> If you read the makefile carefully, you can try "%make_install
> PREFIX=%{buildroot}%{_prefix}". In the next version, use "%make_install
> PREFIX=%{_prefix}".

Looking at your PR the Makefile will change in future versions. That's why I've chosen this way to install the binary at the moment. In the next version I will use your proposal.

Spec URL: https://flo.fedorapeople.org/cv.spec
SRPM URL: https://flo.fedorapeople.org/cv-0.4.1-4.fc20.src.rpm
koji-Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7274442

PACKAGE APPROVED.

Thanks for reviewing!

You forgot to fill the SCM form.

No SCM request found.

New Package SCM Request
=======================
Package Name: cv
Short Description: Coreutils Viewer
Upstream URL: https://github.com/Xfennec/cv
Owners: flo
Branches: f19 f20 f21 el6 epel7
InitialCC:

Git done (by process-git-requests).

(In reply to Christopher Meng from comment #6)
> (In reply to Ralf Corsepius from comment #4)
> > 2. Passing LDFLAGS is not required.
> > => Remove LDFLAGS+="%{?__global_ldflags}" 
> 
> No. It's linked against ncurses. It's a MUST.
Provide a pointer to the FPG, which requires to set __global_ldflags when using ncurses.
 
> (In reply to Florian "der-flo" Lehner from comment #3)
> > Instead of overriding the flags I appended the fedora-default flags.
> 
> Obviously You don't know how to use automake IMO. You are still overriding
> the flags.
This has nothing to do with automake. It's a case of a crappy Makefile.

cv-0.4.1-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/cv-0.4.1-4.fc19

cv-0.4.1-4.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/cv-0.4.1-4.fc20

cv-0.4.1-4.fc20 has been pushed to the Fedora 20 testing repository.

cv-0.4.1-4.fc19 has been pushed to the Fedora 19 stable repository.

cv-0.4.1-4.fc20 has been pushed to the Fedora 20 stable repository.

I doubt if upstream will change name again, now more and more upstream have simple brain and can't came up with any name longer than 3.

Now it's "progress".