Bug 1128445

Summary: [vdsm] - supervdsmServer _getPid required exception handling
Product: Red Hat Enterprise Virtualization Manager Reporter: Eldad Marciano <emarcian>
Component: vdsmAssignee: Michal Skrivanek <michal.skrivanek>
Status: CLOSED DUPLICATE QA Contact: meital avital <mavital>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.4.1-1CC: bazulay, ecohen, gklein, iheim, lpeer, michal.skrivanek, oourfali, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.5.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: virt
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-11 14:04:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Eldad Marciano 2014-08-10 13:58:01 UTC
Description of problem:
there is no exception handling for none pid vms.

/usr/share/vdsm/supervdsmServer

    def _getPid(self):
        pid = '0'
        try:
            vmName = self.conf['vmName'].encode('utf-8')
            pid = supervdsm.getProxy().getVmPid(vmName)
        except Exception:
            pass
        return pid


Version-Release number of selected component (if applicable):
vdsm-4.14.11-1.el6ev.x86_64

How reproducible:
many side affects

Steps to Reproduce:
1.
2.
3.

Actual results:
the process of the vm exist but no pid file.

Expected results:
shutdown vm in case no pid exist.

Additional info:

Comment 1 Eldad Marciano 2014-08-10 14:01:02 UTC
fix should be at this file /usr/share/vdsm/vm.py
not supervdsmServer

Comment 2 Michal Skrivanek 2014-08-11 14:04:42 UTC
will improve as part of bug 1128458

*** This bug has been marked as a duplicate of bug 1128458 ***