Bug 1128697
| Summary: | lightdm-gtk: missing icons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jiri Kastner <jkastner> |
| Component: | lightdm-gtk | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | christoph.wickert, dan.mashal, fedora, gregor, rdieter |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | lightdm-gtk-1.8.5-10.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-12 02:34:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jiri Kastner
2014-08-11 11:32:33 UTC
<shrug>, that's the risk one takes with a minimal install sometimes, similar issues can happen for many things like fonts, locales, etc... I'd rather avoid a hard-coded Requires: gnome-icon-theme if at all possible (since the required icons can theoretically be provided by any theme). On the other hand, seems the .spec already has: # owner of HighContrast gtk/icon themes Requires: gnome-themes-standard So maybe something has changed recently. I'll see what I can find out. And on my f20 box at least, $ rpm -qR gnome-themes-standard ... gnome-icon-theme So either deps have changed, or the icons provided by gnome/HighContrast themes have changed/regressed. Indeed, gnome-themes-standard switched over to Requires: adwaita-icon-theme in http://pkgs.fedoraproject.org/cgit/gnome-themes-standard.git/commit/?id=edc17bb52b815c2b804f49ea4e28aaf86a9de15d And until when/if adwaita-icon-theme provides what we need, will have to continue relying on gnome-icon-theme. %changelog * Mon Aug 11 2014 Rex Dieter <rdieter> 1.8.5-3 - missing icons, +Requires: gnome-icon-theme (#1128697) [11/07/14 10:43] <raveit65> rdieter, hi, are those runtime requires really needed for lightdm-gtk ? http://pkgs.fedoraproject.org/cgit/lightdm-gtk.git/tree/lightdm-gtk.spec#n54 [11/07/14 10:43] <rdieter_work> raveit65: yes, each requires has a comment explaining why [11/07/14 10:44] <rdieter_work> raveit65: are you questioning something in particular? [11/07/14 10:44] <raveit65> rdieter, i think all symbolic-icons which are needed for lightdm-gtk are in adwaitha-icon-theme [11/07/14 10:45] <raveit65> rdieter, i did test it [11/07/14 10:45] <rdieter_work> <nod> that could be true for f21+ now [11/07/14 10:45] <rdieter_work> raveit65: can you file a bug so I don't forget? [11/07/14 10:45] * rdieter_work is working on a bazillion other things atm [11/07/14 10:45] <raveit65> rdieter, i ask because reducing size of livecd [11/07/14 10:46] <raveit65> lightdm is the only package which pulls i the requires [11/07/14 10:47] <raveit65> raveit65, file out a report [11/07/14 10:47] <rdieter_work> raveit65: nvm, I'll reopen the old one %changelog * Fri Nov 07 2014 Rex Dieter <rdieter> 1.8.5-10 - revert +Requires: gnome-icon-theme, adwaita reportedly good enough now (#1128697) In detail i removed gnome-themes-standard and gnome-icon-theme with rpm ....--nodeps. All needed symbolic icons are there which comes from adwaita-icon-theme in f21. So using adwaita-icon-theme shopuld be enough. Only the gtk2 part should be depend on gnome-icon-theme and adwaita-themes-gtk2 packages. I would be great if we can can have a new build before livecd's are tagged for release. hmm, gnome-icon-theme is only for the gtk2 needed, imo lightdm-gtk-1.8.5-10.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/lightdm-gtk-1.8.5-10.fc21 Package lightdm-gtk-1.8.5-10.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lightdm-gtk-1.8.5-10.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-14600/lightdm-gtk-1.8.5-10.fc21 then log in and leave karma (feedback). lightdm-gtk-1.8.5-10.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. in el7/centos7/epel7 is not adwaita-icon-theme available, problem is resolved with gnome-icon-theme-symbolic. [root@gizmo2 ~]# rpm -q lightdm-gtk lightdm-gtk-1.8.5-14.el7.x86_64 I don't have any missing icons (using lightdm-1.8.5-14.el7), and I don't have gnome-icon-theme-symbolic installed. i do not have clasiccal 'desktop' install, i just provisioned minimal rhel7 on usb stick and installed WindowMaker and lightdm. and noticed missing 'settings' icon. i listed on another box, where i don't have missing 'setting' icon and i tried first package i didn't spotted on usb stick install. it was gnome-icon-theme-symbolic, after install restarted and icon appeared. ok, if my settings you mean the 'custom' item in sessions, then yes, I can reproduce. I don't think it's worth adding a dependency (on gnome-icon-theme-symbolic) for that single issue though. |