Bug 1129629
Summary: | Anaconda doesn't recognize insufficient size of /boot partition | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Petr Schindler <pschindl> |
Component: | anaconda | Assignee: | Anaconda Maintenance Team <anaconda-maint-list> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 21 | CC: | anaconda-maint-list, awilliam, g.kaviyarasu, jonathan, jvanek, kparal, robatino, squalyl, vanmeeuwen+fedora |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | AcceptedBlocker | ||
Fixed In Version: | anaconda-21.48.13-1.fc21 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-10-28 23:07:02 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1043124 |
Description
Petr Schindler
2014-08-13 11:48:12 UTC
This block in pyanaconda/storage_utils.py just needs to be updated: checkSizes = [('/usr', 250), ('/tmp', 50), ('/var', 384), ('/home', 100), ('/boot', 75)] Discussed at the 2014-08-13 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2014-08-13/ Rejected as an Alpha blocker. Creating small /boot partition involves custom partitioning which is a Beta criterion. Reproposing for beta blocker. Discussed in 2014-09-24 Blocker Review meeting [1]. Accepted as a blocker. This bug is a clear violation of the Beta Custom partitioning criteria: "Reject or disallow invalid disk and volume configurations without crashing." [1] http://meetbot.fedoraproject.org/fedora-blocker-review/2014-09-24/ Discussed at 2014-10-08 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2014-10-08/f21-blocker-review.2014-10-08-15.58.log.txt . We agreed to ask if this is fixed in F21, but then I realized it's pretty easy to check, and it looks like it isn't. commit a8b3d18792c18ac7d0a2edd254380bc39a17169f from master branch - "Require a larger /boot (#1129629)." - does not appear to exist on f21-branch. Chris, can you backport it? Thanks! This will be in anaconda-21.48.10. *** Bug 1146101 has been marked as a duplicate of this bug. *** anaconda-21.48.10-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/anaconda-21.48.10-1.fc21 Package anaconda-21.48.10-1.fc21, pykickstart-1.99.63-2.fc21, python-blivet-0.61.5-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-21.48.10-1.fc21 pykickstart-1.99.63-2.fc21 python-blivet-0.61.5-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-12944/pykickstart-1.99.63-2.fc21,python-blivet-0.61.5-1.fc21,anaconda-21.48.10-1.fc21 then log in and leave karma (feedback). The change definitely appears on the F21 branch in git, but for some reason doesn't appear to work. In Beta TC4 Workstation live x86_64 custom part I was able to create a 71MB /boot partition and begin installation; nothing stopped me. The correct tuple is definitely in the list in the live image's anaconda. I can only think somehow the error check isn't run or the results are somehow thrown away or something? I can try and look into it a bit more. Ah. I think I have a theory here. The problem is that the value it compares against is no longer just an int representing a number of MB. It's a string, like: "61 MiB" I added a debug print to the check into storage_utils.py to be sure: for (mount, size) in checkSizes: if mount in filesystems: log.info("Size of mount %s is %s", mount, str(filesystems[mount].size)) if mount in filesystems and filesystems[mount].size < size: exns.append( SanityWarning(_("Your %(mount)s partition is less than " "%(size)s megabytes which is lower than " "recommended for a normal %(productName)s " "install.") % {'mount': mount, 'size': size, 'productName': productName})) here's the output I got from it: anaconda.log:12:29:22,809 INFO anaconda: Size of mount /boot is 500 MiB anaconda.log:12:29:32,483 INFO anaconda: Size of mount /boot is 61 MiB see - '61 MiB', not '61'. And here's a quick test script to illustrate the problem: #!/bin/python if '61 MiB' < 200: print("Smaller!") else: print("Larger!") [adamw@adam anaconda (f21-branch %)]$ python /tmp/test.py Larger! so far as python's concerned, '61 MiB' > '200'. for the record I was nearly right, but filesystems[mount].size is actually a blivet Size() object, and I was just getting its __string__ representation. clumens has a patch that should fix this: http://paste.fedoraproject.org/143623/14138339/ I will test it shortly. Tested that change and now the test works indeed, there is now a slight error in the warning message though: ""Your /boot partition is less than 200 MiB megabytes" that'd be easy to fix - just drop the "megabytes" from the warning text - but that would break string freeze. That's a small detail that shouldn't stop us at least making the check work properly. anaconda-21.48.10-1.fc21, pykickstart-1.99.63-2.fc21, python-blivet-0.61.5-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. Re-opening, the fix for this was insufficient. See above. anaconda-21.48.12-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/anaconda-21.48.12-1.fc21 Package anaconda-21.48.12-1.fc21, python-blivet-0.61.7-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-21.48.12-1.fc21 python-blivet-0.61.7-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-13542/python-blivet-0.61.7-1.fc21,anaconda-21.48.12-1.fc21 then log in and leave karma (feedback). I have tested this with Beta RC1 Live and it seems fixed. I was warned whenever I tried to create <200 MB /boot partition. anaconda-21.48.13-1.fc21, python-blivet-0.61.8-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-blivet-0.61.8-1.fc21,anaconda-21.48.13-1.fc21 anaconda-21.48.12-1.fc21, python-blivet-0.61.7-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. anaconda-21.48.13-1.fc21, python-blivet-0.61.8-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |