Bug 1129691

Summary:	Review Request: libde265 - Open H.265 video codec implementation
Product:	[Fedora] Fedora	Reporter:	Joachim Bauch <mail>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED CANTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	anto.trande, package-review, tcallawa
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-14 11:21:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	182235

Description Joachim Bauch 2014-08-13 13:23:20 UTC

Spec URL: http://www.joachim-bauch.de/static/fedora/libde265.spec
SRPM URL: http://www.joachim-bauch.de/static/fedora/libde265-0.8-1.fc20.src.rpm

Description:
libde265 is an open source implementation of the H.265 video codec.
It is written from scratch for simplicity and efficiency. Its simple
API makes it easy to integrate it into other software.

Fedora Account System Username: fancycode

Comment 1 Joachim Bauch 2014-08-13 13:44:02 UTC

Koji build looks good:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7290541

Comment 2 Antonio T. (sagitter) 2014-08-14 10:14:37 UTC

Hi Joachim.

1) Using these tools to build 'configure' scripts and 'Makefiles' is inadvisable. This software already has own scripts, if they are built by too old tools, please, 

  1- point out this to the upstream

 or 

  2- perform 'autogen.sh' outside RPM packaging then apply a patch to update the  configure scripts and Makefile.ins


2) If you don't want to build 'dec265 decoder program' and 'sherlock265 visual inspection program', you can use --disable-dec265  --disable-sherlock265 options; better if you add --disable-silent-rules option, too.

Then, probably, you don't need anymore of the lines 
rm -f %{buildroot}%{_bindir}/dec265
rm -f %{buildroot}%{_bindir}/sherlock265

3) %clean section and '%defattr(-,root,root,-)' are useless.
   Unless this software will be packaged for systems < EPEL6

4) Requires: %{name} = %{version}-%{release} 
   must be arched
   Requires: %{name}%{?_isa} = %{version}-%{release}

Comment 3 Tom "spot" Callaway 2014-08-14 11:21:54 UTC

This one isn't going to get into Fedora, HEVC implementations (of which h265 is one) have exactly the same legal problems as previous codecs backed by the MPEG consortium.