Bug 1129700

Summary: Review Request: php-ircmaxell-security-lib - A Base Security Library
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: php-ircmaxell-security-lib-1.0.0-2.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-02 07:06:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1129714    
Attachments:
Description Flags
phpcompatinfo.log
none
fedora-review.txt none

Description Remi Collet 2014-08-13 13:39:24 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/b49ebcc217a2990adb27cfbf23f9b9e2bda94ed3/php/php-ircmaxell-security-lib/php-ircmaxell-security-lib.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-ircmaxell-security-lib-1.0.0-1.remi.src.rpm
Description: 
This is a base set of libraries used in other projects.
This isn't useful on its own...

Optional dependency: php-gmp or php-bcmath

Fedora Account System Username: remi

Comment 1 Shawn Iwinski 2014-08-13 14:28:50 UTC
Found in lib path: /usr/share/php/SecurityLib/composer.json

Comment 4 Shawn Iwinski 2014-08-27 22:00:07 UTC
Created attachment 931690 [details]
phpcompatinfo.log

phpcompatinfo version 2.26.0

Comment 5 Shawn Iwinski 2014-08-27 22:00:46 UTC
Created attachment 931691 [details]
fedora-review.txt

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1129700
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Comment 6 Shawn Iwinski 2014-08-27 22:02:15 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove after initial import.



No blockers.

===== APPROVED =====

Comment 7 Remi Collet 2014-08-28 14:01:52 UTC
Thanks for the review.


New Package SCM Request
=======================
Package Name: php-ircmaxell-security-lib
Short Description: A Base Security Library
Upstream URL: https://github.com/ircmaxell/SecurityLib
Owners: remi
Branches: f20 f21 el6 epel7
InitialCC:

Comment 8 Gwyn Ciesla 2014-08-28 15:31:09 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2014-08-28 16:46:26 UTC
php-ircmaxell-security-lib-1.0.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/php-ircmaxell-security-lib-1.0.0-2.fc21

Comment 10 Fedora Update System 2014-08-28 16:46:34 UTC
php-ircmaxell-security-lib-1.0.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-ircmaxell-security-lib-1.0.0-2.fc20

Comment 11 Fedora Update System 2014-08-28 16:46:57 UTC
php-ircmaxell-security-lib-1.0.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-ircmaxell-security-lib-1.0.0-2.el6

Comment 12 Fedora Update System 2014-08-29 14:42:48 UTC
php-ircmaxell-security-lib-1.0.0-2.fc21 has been pushed to the Fedora 21 testing repository.

Comment 13 Fedora Update System 2014-09-09 22:25:32 UTC
php-ircmaxell-security-lib-1.0.0-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 14 Fedora Update System 2014-09-23 04:52:56 UTC
php-ircmaxell-security-lib-1.0.0-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 15 Fedora Update System 2014-09-24 03:50:38 UTC
php-ircmaxell-security-lib-1.0.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.