Bug 1129714

Summary: Review Request: php-ircmaxell-random-lib - A Library For Generating Secure Random Numbers
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: php-ircmaxell-random-lib-1.0.0-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-01 16:56:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1129700    
Bug Blocks:    
Description Flags
phpcompatinfo.log none

Description Remi Collet 2014-08-13 14:11:44 UTC
Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/e98e681b1eedcd64031ee5a8031bba4d15d02755/php/php-ircmaxell-random-lib/php-ircmaxell-random-lib.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-ircmaxell-random-lib-1.0.0-1.remi.src.rpm
A library for generating random numbers and strings of various strengths.

This library is useful in security contexts.

Fedora Account System Username: remi

-- This is an optional dependency of ZendFramework 2

Comment 1 Shawn Iwinski 2014-10-27 01:08:01 UTC
Created attachment 950868 [details]

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 1129714
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby

Comment 2 Shawn Iwinski 2014-10-27 01:08:35 UTC
Created attachment 950869 [details]

phpcompatinfo version 2.26.0

Comment 3 Shawn Iwinski 2014-10-27 01:10:11 UTC
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     Note: %clean present but not required

As usual, remove after initial import.

No blockers.

===== APPROVED =====

Comment 4 Remi Collet 2014-10-27 05:58:12 UTC
Thanks for the review!

New Package SCM Request
Package Name: php-ircmaxell-random-lib
Short Description: A Library For Generating Secure Random Numbers
Upstream URL: https://github.com/ircmaxell/RandomLib
Owners: remi
Branches: f20 f21 el6 epel7

Comment 5 Gwyn Ciesla 2014-10-27 12:06:01 UTC
Git done (by process-git-requests).

Comment 6 Fedora Update System 2014-10-27 13:03:17 UTC
php-ircmaxell-random-lib-1.0.0-1.el7 has been submitted as an update for Fedora EPEL 7.

Comment 7 Fedora Update System 2014-10-27 13:03:25 UTC
php-ircmaxell-random-lib-1.0.0-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 8 Fedora Update System 2014-10-27 13:03:32 UTC
php-ircmaxell-random-lib-1.0.0-1.fc21 has been submitted as an update for Fedora 21.

Comment 9 Fedora Update System 2014-10-27 13:03:39 UTC
php-ircmaxell-random-lib-1.0.0-1.fc20 has been submitted as an update for Fedora 20.

Comment 10 Fedora Update System 2014-10-28 06:45:28 UTC
php-ircmaxell-random-lib-1.0.0-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 11 Fedora Update System 2014-11-01 16:56:29 UTC
php-ircmaxell-random-lib-1.0.0-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 12 Fedora Update System 2014-11-07 02:34:00 UTC
php-ircmaxell-random-lib-1.0.0-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 13 Fedora Update System 2014-11-12 23:16:34 UTC
php-ircmaxell-random-lib-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.

Comment 14 Fedora Update System 2014-11-12 23:17:28 UTC
php-ircmaxell-random-lib-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.