Bug 1130026

Summary: FreeSpaceCriticalLowInGB variable takes negative values
Product: [Retired] oVirt Reporter: Ori Gofen <ogofen>
Component: ovirt-engine-configAssignee: Allon Mureinik <amureini>
Status: CLOSED DUPLICATE QA Contact: Aharon Canan <acanan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.5CC: acanan, acathrow, amureini, ecohen, gklein, iheim, yeylon
Target Milestone: ---Keywords: Triaged
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-14 12:54:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ori Gofen 2014-08-14 08:15:12 UTC
Description of problem:
FreeSpaceCriticalLowInGB is a flag that warns the user when a domain has reached threshold level and prevent from creating new disks,however, this variable needs to unsigned because we do not want it to take negative values.

this is the default flag state:

root@ovirt-gofen-1 ~ # engine-config -g FreeSpaceCriticalLowInGB      
FreeSpaceCriticalLowInGB: 5 version: general

now I'm forcing FreeSpaceCriticalLow to be -3:

root@ovirt-gofen-1 ~ # engine-config -s FreeSpaceCriticalLowInGB=-3

check that the value is kept:

root@ovirt-gofen-1 ~ # engine-config -g FreeSpaceCriticalLowInGB   
FreeSpaceCriticalLowInGB: -3 version: general

Version-Release number of selected component (if applicable):
rc1

How reproducible:
100%

Steps to Reproduce:
1.engine-config -s FreeSpaceCriticalLowInGB=NEGATIVE_VALUE
2.restart engine

Actual results:
domain's has invalid free space threshold

Expected results:
domain's free space threshold > 0

Additional info:

Comment 1 Aharon Canan 2014-08-14 12:54:43 UTC
please check 1130026
This was opened as dup by mistake.

*** This bug has been marked as a duplicate of bug 1130030 ***