Bug 1130185

Summary:	Review Request: python-icontrol - Library for F5 iControl API
Product:	[Fedora] Fedora	Reporter:	Daniel Bruno <dbruno>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	e, orion, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-11 18:07:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Bruno 2014-08-14 13:59:04 UTC

Spec URL: https://dbruno.fedorapeople.org/python-icontrol/python-icontrol.spec
SRPM URL: https://dbruno.fedorapeople.org/python-icontrol/python-icontrol-2.1-1.fc20.src.rpm
Description: pyControl is a Python-based library that integrates with F5's BIG-IP
iControl management API.
Fedora Account System Username: dbruno

Comment 1 Eduardo Mayorga 2014-08-28 22:54:10 UTC

- Remove egg-info directory in %prep.

- These are obsolete:
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

%clean
rm -rf %{buildroot}

and there's no need to add rm -rf %{buildroot} in %install

- You must include a license text in %doc. Since this project seems not to be maintained, it will be tricky to get this mistake corrected. For now, please add a copy of the text of the GPL. Something like Source1: COPYING would be fine.

- Change the name to python-pycontrol, since it's the name used by upstream and the actual module name used to import it in a script