Bug 1130220

Summary:	HostObserver#token tests failing due to missed cherry pick dependency
Product:	Red Hat Satellite	Reporter:	Greg Sutcliffe <gsutclif>
Component:	Other	Assignee:	Greg Sutcliffe <gsutclif>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dominic Cleal <dcleal>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.0.4	CC:	dcleal, gsutclif, jmontleo, sthirugn, tkolhar
Target Milestone:	Unspecified	Keywords:	OtherQA, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-11 12:26:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Greg Sutcliffe 2014-08-14 14:56:12 UTC

When [1] was cherry-picked, there was a merged conflict which was resolved by changing the commit. In fact, the real cause was that the source of the cherry-pick[2] depended on a secondary commit[3]. This dependency contained the necessary test fixture changes to support the patch, and without it, tests are now failing[4].

A PR is incoming with a modified version of [3] to fix the issue.

[1] https://gitlab.sat.lab.tlv.redhat.com/satellite6/foreman/commit/dfb03f82cdf8677a9f1b63030ec69b9722723e45
[2] https://github.com/theforeman/foreman/commit/316d78c0e96f56cef760694db4523f651744e4e3
[3] https://github.com/theforeman/foreman/commit/6568415c2bf5493bc344eeeedebbe26f8723b7d3
[4] http://jenkinsmaster.sat.lab.tlv.redhat.com/job/test_develop/database=mysql,ruby=1.8.7/818/testReport/junit/%28root%29/HostObserverTest/test_0001_tokens_should_be_removed_based_on_build_state/

Comment 1 RHEL Program Management 2014-08-14 15:03:23 UTC

Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Greg Sutcliffe 2014-08-14 15:20:17 UTC

code at https://gitlab.sat.lab.tlv.redhat.com/satellite6/foreman/merge_requests/22

Comment 5 Tazim Kolhar 2014-08-27 12:29:11 UTC

please provide verification steps

Comment 7 Bryan Kearney 2014-09-11 12:26:33 UTC

This was delivered with Satellite 6.0 which was released on 10 September 2014.