Bug 1130341
Summary: | Agent can block indefinitely if it has received a remote command at startup but then asked to shutdown | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Elias Ross <genman> |
Component: | Agent | Assignee: | Thomas Segismont <tsegismo> |
Status: | ON_QA --- | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.9 | CC: | hrupp, tsegismo |
Target Milestone: | --- | ||
Target Release: | RHQ 4.13 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | Type: | Bug | |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Elias Ross
2014-08-15 00:22:13 UTC
Fixed in master, thanks Elias. Branch: refs/heads/master Home: https://github.com/rhq-project/rhq Commit: 27af90bb1aa82733ce022596f8fcf1f4564d11d3 https://github.com/rhq-project/rhq/commit/27af90bb1aa82733ce022596f8fcf1f4564d11d3 Author: Elias Ross <elias_ross> Date: 2014-10-15 (Wed, 15 Oct 2014) Changed paths: M modules/enterprise/agent/src/main/java/org/rhq/enterprise/agent/AgentMain.java M modules/enterprise/comm/src/main/java/org/rhq/enterprise/communications/command/server/CommandProcessor.java Log Message: ----------- BZ 1130341 - Agent can be stuck waiting for startup The agent can block forever in a JBoss remoting callback if it receives a message that triggers a wait on the latch. Change to wait a finite amount of time, then throw an exception. Also, clean up the CommandProcessor to use CopyOnWriteArrayList, no need to copy lists like this. Commit: db607e13a2772f6655399e418875a0a45e373ab9 https://github.com/rhq-project/rhq/commit/db607e13a2772f6655399e418875a0a45e373ab9 Author: Elias Ross <elias_ross> Date: 2014-10-17 (Fri, 17 Oct 2014) Changed paths: M modules/enterprise/agent/src/main/java/org/rhq/enterprise/agent/AgentMain.java Log Message: ----------- For timeout at startup, use 30 seconds (fixed) Commit: a260f33265a26ddf64c3372380c8c09f7b5be82c https://github.com/rhq-project/rhq/commit/a260f33265a26ddf64c3372380c8c09f7b5be82c Author: Elias Ross <elias_ross> Date: 2014-11-03 (Mon, 03 Nov 2014) Changed paths: M modules/enterprise/agent/src/main/java/org/rhq/enterprise/agent/AgentMain.java Log Message: ----------- Use NotProcessedException to indicate startup latch timed out Commit: 288fac0e6a540061a940d0d3be8b69e79e15e8bd https://github.com/rhq-project/rhq/commit/288fac0e6a540061a940d0d3be8b69e79e15e8bd Author: Thomas Segismont <tsegismont> Date: 2014-11-20 (Thu, 20 Nov 2014) Changed paths: M modules/enterprise/agent/src/main/java/org/rhq/enterprise/agent/AgentMain.java M modules/enterprise/comm/src/main/java/org/rhq/enterprise/communications/command/server/CommandProcessor.java Log Message: ----------- Merge pull request #141 from genman/bug/1130341 BZ 1130341 - Agent can be stuck waiting for startup Compare: https://github.com/rhq-project/rhq/compare/9fa2131e6a62...288fac0e6a54 |