Bug 1130373

Summary: [RFE][neutron]: Common standard for assertEqual usage in neutron unit testing
Product: Red Hat OpenStack Reporter: RHOS Integration <rhos-integ>
Component: RFEsAssignee: RHOS Maint <rhos-maint>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: markmc, yeylon
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://blueprints.launchpad.net/neutron/+spec/assertequal-standard-usage
Whiteboard: upstream_milestone_none upstream_definition_approved upstream_status_implemented
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-19 16:58:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description RHOS Integration 2014-08-15 04:04:24 UTC 
Cloned from launchpad blueprint https://blueprints.launchpad.net/neutron/+spec/assertequal-standard-usage.

Description:

This BP comes to define a standard usage of assertEqual() function in Neutron unit testing code.

Neutron Unit Testing code uses assertEqual() function in all it's unit testing modules and classes.
The signature of this function is assertEqual(self, expected, observed, message='')
Values for comparison should be in order of expected value comes first, actual value comes after.

There is no standard of using this function in Neutron unit testing.
Function is called in both ways, assertEqual(expected, observed) and assertEqual(observed, expected)
while the second case seems to be preferable.

Neutron unit testing code should have standard usage of assertEqual() function 
that fits its assertEqual(expected, observed) signature




Specification URL (additional information):

None