Bug 1130581
| Summary: | Review Request: perl-Devel-CheckBin - Check that a command is available | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Paul Howarth <paul> |
| Component: | Package Review | Assignee: | David Dick <ddick> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ddick, package-review |
| Target Milestone: | --- | Flags: | ddick:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Devel-CheckBin-0.02-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-03 14:58:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Paul Howarth
2014-08-15 15:14:24 UTC
License is correct. Not often that ExtUtils::MakeMaker is a runtime requirement! tests require /bin/ls which is included in coreutils, therefore is correctly not mentioned in BRs. Build and RunTime Requires ok. rpmlint is clean. builds cleanly in rawhide : http://koji.fedoraproject.org/koji/taskinfo?taskID=7358903 module has not already been packaged : https://admin.fedoraproject.org/pkgdb/packages/perl-Devel-CheckBin*/ https://fedoraproject.org/wiki/How_to_create_an_RPM_package says that %license is not a valid prefix in fedora. Please change to %doc. Package APPROVED. Thanks for the review David. %license is a fairly recent innovation and is now preferred to %doc for license files: http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image New Package SCM Request ======================= Package Name: perl-Devel-CheckBin Short Description: Check that a command is available Upstream URL: http://search.cpan.org/dist/Devel-CheckBin/ Owners: pghmcfc Branches: f19 f20 f21 epel7 InitialCC: perl-sig Git done (by process-git-requests). perl-Devel-CheckBin-0.02-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Devel-CheckBin-0.02-2.fc20 perl-Devel-CheckBin-0.02-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Devel-CheckBin-0.02-2.fc19 perl-Devel-CheckBin-0.02-2.fc19 has been pushed to the Fedora 19 stable repository. perl-Devel-CheckBin-0.02-2.fc20 has been pushed to the Fedora 20 stable repository. |