Bug 1131254
| Summary: | RFE: use the suggested-action style class for the "Begin Installation" button | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elad Alfassa <elad> |
| Component: | anaconda | Assignee: | David Shea <dshea> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | anaconda-maint-list, dshea, duffy, g.kaviyarasu, jonathan, mkolman, vanmeeuwen+fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | anaconda-21.48.8-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-11 06:53:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Elad Alfassa
2014-08-18 19:24:21 UTC
Máirín, would the suggested-action class be appropriate for the begin installation button or the continue buttons on standalone spokes (such as the welcome screen)? Asking since you set suggestion-action on the Done buttons in spokes, and I vaguely remember this discussion coming up before but can't actually find it. Yes! We had talked about doing this earlier and there was some technical reason we couldn't at the time, I don't remember what. But if there's no blockers to doing it now - yeh! It'd be totally appropriate for the begin installation button as well as the done buttons in the spokes. Pushed to master as a38c600e9d44fdfbf6d535bd58731e1f98caa2c5, leaving this bug around so I remember to push to f21 after the alpha freeze. Note that if the top bar of spokes (where the title is) is to remain blue (why is it blue? I don't know) then using this style for individual spokes is wrong, because blue on blue does the opposite of what this style is intended for - to attract the eye to that button. the artwork in anaconda for f21 right now is just placeholder - we can make it dark fedora blue so the lighter blue will pop against it. :) good point tho anaconda-21.48.8-1.fc21, python-blivet-0.61.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-blivet-0.61.3-1.fc21,anaconda-21.48.8-1.fc21 Package anaconda-21.48.8-1.fc21, python-blivet-0.61.3-1.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-21.48.8-1.fc21 python-blivet-0.61.3-1.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-11977/python-blivet-0.61.3-1.fc21,anaconda-21.48.8-1.fc21 then log in and leave karma (feedback). Package anaconda-21.48.8-1.fc21, python-blivet-0.61.3-1.fc21, pykickstart-1.99.60-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-21.48.8-1.fc21 python-blivet-0.61.3-1.fc21 pykickstart-1.99.60-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-11977/pykickstart-1.99.60-2.fc21,python-blivet-0.61.3-1.fc21,anaconda-21.48.8-1.fc21 then log in and leave karma (feedback). anaconda-21.48.8-1.fc21, python-blivet-0.61.3-1.fc21, pykickstart-1.99.60-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |