Bug 1131423

Summary:	Review Request: menhir - LR(1) parser generator for OCaml
Product:	[Fedora] Fedora	Reporter:	Richard W.M. Jones <rjones>
Component:	Package Review	Assignee:	François Cami <contribs>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	contribs, loganjerry, package-review, scottt.tw
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-19 15:58:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2014-08-19 08:58:59 UTC

Spec URL: http://oirase.annexia.org/reviews/menhir/menhir.spec
SRPM URL: http://oirase.annexia.org/reviews/menhir/menhir-20140422-1.fc20.src.rpm
Description: LR(1) parser generator for OCaml
Fedora Account System Username: rjones

Comment 1 Richard W.M. Jones 2014-08-19 09:00:10 UTC

Menhir is required for js-of-ocaml >= 2.  Adding js-of-ocaml maintainer.

Comment 2 Richard W.M. Jones 2014-08-19 09:02:16 UTC

rpmlint output:

menhir.src: W: spelling-error %description -l en_US ocamlyacc -> bellyache
menhir.src:77: W: macro-in-comment %doc
menhir.x86_64: W: spelling-error %description -l en_US ocamlyacc -> bellyache
menhir.x86_64: W: doc-file-dependency /usr/share/doc/menhir/demos/ocamldep.wrapper /usr/bin/env
menhir.x86_64: W: ocaml-naming-policy-not-applied /usr/lib64/ocaml/menhirLib/META
menhir-devel.x86_64: W: ocaml-naming-policy-not-applied /usr/lib64/ocaml/menhirLib/menhirLib.cmx
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

Note "ocaml-naming-policy-not-applied" happens because rpmlint
thinks the package should be called "ocaml-*".  However in this
case the package is just called menhir upstream and since it is
a standalone program ("/usr/bin/menhir") that seems a reasonable
name for the Fedora package too.

Comment 3 Richard W.M. Jones 2014-08-19 09:03:30 UTC

Successful scratch build in Rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=7426201

Comment 4 François Cami 2014-08-19 15:38:49 UTC

Taken, review coming soon.

Comment 5 Jerry James 2014-08-19 15:54:59 UTC

How is this different from the existing ocaml-menhir package?

Comment 6 Richard W.M. Jones 2014-08-19 15:56:37 UTC

(In reply to Jerry James from comment #5)
> How is this different from the existing ocaml-menhir package?

Am I gonna look stupid here?

Comment 7 Richard W.M. Jones 2014-08-19 15:58:08 UTC

Yes I am.

This package already exists in Fedora.  Sorry about that.