Bug 1131755

Description of problem:

This issue had been confirmed with "Jiri Denemark" <jdenemar> , here is mail info:
--------------------------------------------------------------------------
++My Question:
On rhel7,  press ctrl+c to interrupt the save job, the guest will be shutoff and the error will show:
"error: Requested operation is not valid: domain is not running", this is not right.

on rhel6.6, press ctrl+c to interrupt the save job, the guest is still running and the error will show:
"error: Failed to save domain rhel6 to savefile
error: operation aborted: domain save job: canceled by client", this is right. 


++Jiri's reply:
This would suggest that saving was very fast and finished before you
tried to cancel it. Is the savefile correct at this point (i.e., can you
restore the domain from it?

++My Response:
Yes, I could restore domain from savefile.
But, normally, If "virsh save" process finished successfully, A string "Domain xx saved to savefile" should output.
For example:
-----------------------------------------------------------
[root@rhel7 ~]# virsh list
 Id    Name                           State
------------------------------------------------
 76    rhel6u5_D                      running
[root@rhel7 ~]# virsh  save rhel6u5_D  savefile

Domain rhel6u5_D saved to savefile
-----------------------------------------------------------
Currently, if press ctrl+c to interrupt the save job, the string "Domain xx saved to savefile" was not output.
I guess whether the SIGINT signal interrupts after the save job finished but before the "save process" finished ?
That is to say, savefile was generated successfully, but above error outputs instead of "Domain xx saved to savefile" output.
The "error: Requested operation is not valid: domain is not running" seems unreasonable and useless.


++Jiri's reply:
I see, that's probably a bug in virsh which reports the error from
virDomainJobAbort instead of reporting success from the original API

---------------------------------------------------------------------------


Version-Release number of selected component (if applicable):
libvirt-1.2.7-1.el7.x86_64
qemu-kvm-rhev-2.1.0-1.el7.x86_64
kernel-3.10.0-142.el7.x86_64


How reproducible:
100%

Steps to Reproduce:
1.Prepare a running guest named "rhel6-new", execute the following commands:

[root@rhel7-a ~]# virsh list
   Id    Name                           State
----------------------------------------------------
   13    rhel6-new                      running

2. After running virsh save command and wait a half of or a second, Press keys ctrl+c to interrupt the save job
[root@rhel7-a ~]# virsh save rhel6-new /tmp/rhel6.save
^Cerror: Requested operation is not valid: domain is not running

3. Check guest's status.
[root@rhel7-a ~]# ^C
[root@rhel7-a ~]# virsh list
   Id    Name                           State
----------------------------------------------------

[root@rhel7-a ~]# virsh list --all
   Id    Name                           State
----------------------------------------------------
   -     rhel6-new                      shut off




Actual results:
1. The guest is shutoff and error msg is not right.
2. save file /tmp/rhel6.save generated successfully and could restore from it.


Expected results:
1. Success report "Domain rhel6-new saved to savefile" should output since save file generated successfully.
OR
2. The guest should be kept running and the error msg should just like:
"error: Failed to save domain rhel6-new to savefile
error: operation aborted: domain save job: canceled by client"


Additional info:
This issue does not occur on rhel6.6


on rhel6.6:
[root@rhel6 ~]# virsh list
   Id    Name                           State
----------------------------------------------------
   11    rhel6                          running

[root@rhel6 ~]# virsh save rhel6 savefile
^Cerror: Failed to save domain rhel6 to savefile
error: operation aborted: domain save job: canceled by client

[root@rhel6 ~]# ^C
[root@rhel6 ~]# virsh list
   Id    Name                           State
----------------------------------------------------
   11    rhel6                          running