Bug 1131812

Summary: An unprivileged attachment reviewer cannot update the attachment's review flag.
Product: [Community] Bugzilla Reporter: Rony Gong 🔥 <qgong>
Component: Attachments/RequestsAssignee: Jeff Fearn 🐞 <jfearn>
Status: CLOSED CURRENTRELEASE QA Contact: Rony Gong 🔥 <qgong>
Severity: low Docs Contact:
Priority: medium    
Version: 4.4CC: jmcdonal, mtyson
Target Milestone: 4.4Keywords: TestCaseApproved, TestCaseProvided
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.4.9039 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-20 23:29:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Test Attachment none

Comment 1 Jason McDonald 2014-09-01 06:26:31 UTC
Created attachment 933246 [details]
Test Attachment

Comment 2 Jason McDonald 2014-09-01 06:38:47 UTC
(Original description made private as it mentions an internal server.)

Description of problem:
An unprivileged attachment reviewer cannot update the attachment's review flag.

Version-Release number of selected component (if applicable):
4.4.5024

How reproducible:
Always

Steps to Reproduce:
1. Create an attachment on a bug and request the review? flag on that attachment of a user who has no group privileges.
2. Login as the user of whom the flag was requested and attempt to respond to the flag in the Attachment Details page.

Actual results:
The unprivileged user cannot edit the review flag on the attachment.

Expected results:
The unprivileged user can set review+ or review- on the attachment.

Additional info:
The test attachment on this bug has review? requested of my unprivileged personal account.  When I log to that account and view the attachment details page, I see the flag shown as plain text, where I should see a drop-down list of the available flag states.

Comment 4 Rony Gong 🔥 2015-06-16 07:36:41 UTC
Tested on 
QA environment(bzweb01-qe) with version(4.4.9035-1, DB: mysql)
QA environment(bzperfweb01.app.qa) with version(4.4.9035-1, DB: psql )
Result: Pass

Comment 5 Matt Tyson 🤬 2015-09-20 23:29:08 UTC
This change is now live. If there are any issues, do not reopen this bug.
Instead, you should create a new bug and reference this bug.