Bug 1131825
Summary: | Review Request: qtile - Small, flexible, scriptable tiling window manager | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> | ||||
Component: | Package Review | Assignee: | Tomas Dabašinskas <tdabasin> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | athmanem, i, jdulaney, package-review, projects.rg, tdabasin | ||||
Target Milestone: | --- | Flags: | tdabasin:
fedora-review?
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-01-31 00:47:19 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 1140886 | ||||||
Bug Blocks: | 201449 | ||||||
Attachments: |
|
Description
Christopher Meng
2014-08-20 06:48:51 UTC
Created attachment 937123 [details]
qtile startup
Thanks for packaging qtile, here's couple of notes that might help future reviewer:
1) Either remove shebang line (!#) or make .py files executable:
qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/confreader.py 0644L /usr/bin/env
qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/widget/bitcoin_ticker.py 0644L /usr/bin/env
qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/widget/yahoo_weather.py 0644L /usr/bin/env
qtile.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/libqtile/widget/sensors.py 0644L /usr/bin/env
2) You need to file a bug against pycairo since it was compiled without xpyd (python xcb binding) which makes qtile unable to starts, attached the output.
Regarding note 2, xcb and xpyb support has been enabled in 1.8.10-8 %changelog +* Sat Sep 07 2013 Tomas Dabasinskas <tdabasin> - 1.8.10-8 +- Enabling xcb and xpyb + Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1005447 Many thanks Christopher! Taking up review Scratch build ok: [packager@33b32ae1ef19 ~]$ koji build --scratch rawhide qtile-0.8.0-1.fc22.src.rpm Uploading srpm: qtile-0.8.0-1.fc22.src.rpm [====================================] 100% 00:00:03 276.85 KiB 73.45 KiB/sec Created task: 7752110 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7752110 Watching tasks (this may be safely interrupted)... 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm) completed successfully /bin/qtile has import pkg_resources which is in python-setuptools, should it be included as Requires? Having trouble with mock, unable to run fedora-review (In reply to Tomas Dabašinskas from comment #5) > Scratch build ok: > [packager@33b32ae1ef19 ~]$ koji build --scratch rawhide > qtile-0.8.0-1.fc22.src.rpm > Uploading srpm: qtile-0.8.0-1.fc22.src.rpm > [====================================] 100% 00:00:03 276.85 KiB 73.45 > KiB/sec > Created task: 7752110 > Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7752110 > Watching tasks (this may be safely interrupted)... > 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open > (buildvm-19.phx2.fedoraproject.org) > 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open > (buildvm-03.phx2.fedoraproject.org) > 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open > (buildvm-03.phx2.fedoraproject.org) -> closed > 0 free 1 open 1 done 0 failed > 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open > (buildvm-19.phx2.fedoraproject.org) -> closed > 0 free 0 open 2 done 0 failed > > 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm) completed successfully > > /bin/qtile has import pkg_resources which is in python-setuptools, should it > be included as Requires? > > Having trouble with mock, unable to run fedora-review I will ask upstream about that. Will you take this review? If so you can assign and change the bug status. Thanks, I'm busy... As upstream seems to be very active, I would like to see a qtile package in Fedora. So I could be (co-)maintainer or take the review if you are lacking out of time or may like to give away ownership. Thanks for the offer Raphael, that would be great, please go ahead with the review. Please note python-setuptools must be included as a dependency for qtile Proposed F22 Self Contained Change: https://fedoraproject.org/wiki/Changes/qtile 0.9.0 is the latest release of qtile; I have packaged the dependencies in Fedora and was planning on packaging 0.9.0. I would suggest packaging the latest version; I'll gladly help. Who is the packager here? I can help with the review, mostly. No reply from Christopher Meng in quite some time; as the deadline for getting things into F22 is coming fast, something needs to be done. I have qtile 0.9 ready to go for a review request. I would also like to point out that I had started pacaging deps for qtile prior to this review request. So I'll close as dead review cause it is quite obvious now. Feel free to duplicate (reopen) to start a new review process. *** This bug has been marked as a duplicate of bug 1188093 *** |