Bug 1131991
| Summary: | Review Request: rubygem-logstash-event - Classes required to create LogStash events | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | František Dvořák <valtri> |
| Component: | Package Review | Assignee: | Josef Stribny <jstribny> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, jstribny, package-review, slukasik |
| Target Milestone: | --- | Flags: | jstribny:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-logstash-event-1.2.02-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-09-09 22:20:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
František Dvořák
2014-08-20 13:22:43 UTC
I will take it for a review. The following SRPM URL cannot be accessed: SRPM URL: http://scientific.zcu.cz/fedora/rubygem-logstash-event-1.2.02-1/rubygem-logstash-event-1.2.02-0.fc22.src.rpm Oh, I'm sorry, wrong URL. (I've probably copied old rpm name I used for COPR...) Proper URLs: Spec URL: http://scientific.zcu.cz/fedora/rubygem-logstash-event-1.2.02-1/rubygem-logstash-event.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-logstash-event-1.2.02-1/rubygem-logstash-event-1.2.02-1.fc22.src.rpm Could we make the description a little bit useful? It doesn't add any value when it's the same as summary. The package goal is not much bigger, but at least some reformulation was really needed and in the end I was able to add some extra information too. :-) Also I found missing dependency on json in gemfile (during working on logstasher). Current upstream changed parts around json already, so I haven't reported it. Spec URL: http://scientific.zcu.cz/fedora/rubygem-logstash-event-1.2.02-2/rubygem-logstash-event.spec SRPM URL: http://scientific.zcu.cz/fedora/rubygem-logstash-event-1.2.02-2/rubygem-logstash-event-1.2.02-2.fc22.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7464638 * Wed Aug 27 2014 František Dvořák <valtri.cz> - 1.2.02-2 - More elaborate description - Added explicit require on json rubygem > The package goal is not much bigger, but at least some reformulation was > really needed and in the end I was able to add some extra information too. :-) Great. > Also I found missing dependency on json in gemfile Actually, json comes with Ruby on Fedora :), so that dependency is not really needed, but it's better that it's stated. Rpmlint doesn't compain, package builds, installs, runs, spec looks sane => APPROVED. [0] https://github.com/elasticsearch/logstash/commit/e03b67dc7da0c3d654caef9ca1a144d1ab99e580 New Package SCM Request ======================= Package Name: rubygem-logstash-event Short Description: Classes required to create LogStash events Upstream URL: https://github.com/logstash/logstash Owners: valtri Branches: f19 f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). rubygem-logstash-event-1.2.02-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-logstash-event-1.2.02-2.fc21 rubygem-logstash-event-1.2.02-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/rubygem-logstash-event-1.2.02-2.fc20 rubygem-logstash-event-1.2.02-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/rubygem-logstash-event-1.2.02-2.fc19 rubygem-logstash-event-1.2.02-2.fc21 has been pushed to the Fedora 21 testing repository. rubygem-logstash-event-1.2.02-2.fc20 has been pushed to the Fedora 20 stable repository. rubygem-logstash-event-1.2.02-2.fc19 has been pushed to the Fedora 19 stable repository. rubygem-logstash-event-1.2.02-2.fc21 has been pushed to the Fedora 21 stable repository. |