Bug 1132260

Summary:	[GUI over REST API gaps] missing network labels support as part of the setup networks api
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Einav Cohen <ecohen>
Component:	ovirt-engine-webadmin-portal	Assignee:	Alona Kaplan <alkaplan>
Status:	CLOSED NOTABUG	QA Contact:	Meni Yakove <myakove>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	3.5.0	CC:	alkaplan, bazulay, ecohen, gklein, iheim, lsurette, masayag, oramraz, rbalakri, Rhev-m-bugs, yeylon, ykaul, ylavi
Target Milestone:	---	Keywords:	CodeChange
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	network
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-11 08:46:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1132506

Description Einav Cohen 2014-08-21 02:28:50 UTC

based on feedback on rhevm-staff mailing list [1], network labels support (as part of the setup networks api) is missing from the rest api. 

[1] https://post-office.corp.redhat.com/mailman/private/rhevm-staff/2014-April/msg00012.html

Comment 1 Lior Vernia 2015-02-12 14:43:30 UTC

Moti, correct me if I'm wrong, but the new NetworkAttachment API doesn't include references to labels (as this isn't an attachment-related attribute). So this refers to having the frontend call the label/unlabel commands exposed via REST directly, instead of trusting the backend setup networks command to perform this?

Comment 2 Moti Asayag 2015-02-15 12:05:59 UTC

(In reply to Lior Vernia from comment #1)
> Moti, correct me if I'm wrong, but the new NetworkAttachment API doesn't
> include references to labels (as this isn't an attachment-related
> attribute). So this refers to having the frontend call the label/unlabel
> commands exposed via REST directly, instead of trusting the backend setup
> networks command to perform this?

Yes. Network labels are properties of the network interfaces. In the new api we do not send list of interfaces and their properties. Instead we send only their identifiers (except bonds which requires more info).

The label/unlabel nic commands might trigger additional setup-networks calls, hence I'd suggest first to send the setup-network command which attaches the networks to the nics or removes networks from the nics.

Once this action is performed, the label/unlabel nic will be translated simply to a db call and will be terminated immediately.

So it is doable without modifying any api, and basically there is no gap here.

Comment 3 Lior Vernia 2015-02-15 12:38:52 UTC

Thanks, so this indeed seems like it belongs to the frontend component.

Comment 5 Barak 2015-05-04 09:21:14 UTC

Alona,

Per comment #2
Is this  something doable for 3.6 , estimated time ?

Comment 6 Moti Asayag 2015-05-04 09:43:21 UTC

(In reply to Barak from comment #5)
> Alona,
> 
> Per comment #2
> Is this  something doable for 3.6 , estimated time ?

As explained in comment #2, i don't think there is a need to extend the api to support network labels.

The UI is using the new host networking api [1] (haven't reviewed yet), and should compensate the lack of the labels functionality by a consequences api calls to LabelNicCommand and UnlabelNicCommand.

So as far as it concerns this bug, it should be closed.

[1] https://gerrit.ovirt.org/#/c/38234/

Comment 7 Barak 2015-05-11 08:38:34 UTC

Per comment #6 closing this bug as NOTABUG.

Comment 8 Alona Kaplan 2015-08-03 11:20:04 UTC

Eventually, we've added the labels to the new setup networks api.
The api was incomplete without the networks.
The suggestion of first adding/removing the networks and then calling the Label/UnLabel command is not doable since removing a network attached via a label via the setup network is forbidden.