Bug 1132299

Summary: Exit status is zero though oo-admin-cartridge failed to install the cartridge.
Product: OpenShift Online Reporter: Liang Xia <lxia>
Component: ContainersAssignee: Jhon Honce <jhonce>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 2.xCC: dmcphers, jokerman, mmccomas, sztsian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1171257 (view as bug list) Environment:
Last Closed: 2015-07-07 23:49:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1171257    

Description Liang Xia 2014-08-21 06:12:48 UTC 
Description of problem:
Exit status is zero though oo-admin-cartridge failed to install the cartridge.

Version-Release number of selected component (if applicable):
devenv_5100

How reproducible:
always

Steps to Reproduce:
1.SSH into instance and run following commands:
# oo-admin-cartridge --action install --source /tmp ; echo $?

Actual results:
# oo-admin-cartridge --action install --source /tmp ; echo $?
install failed for /tmp: Cartridge manifest.yml missing: '/tmp/metadata/manifest.yml'
installation failed
0

Expected results:
The exit status should not be zero since the install failed.

Additional info:
Comment 1 Zamir SUN 2014-08-28 03:13:20 UTC 
pull request https://github.com/openshift/origin-server/pull/5767
Comment 2 Jhon Honce 2014-08-28 17:26:48 UTC 
oo-admin-cartridge is expected to return 0 if at least one cartridge was installed.
Comment 3 Dan McPherson 2015-06-12 02:09:11 UTC 
Is there anything left to fix?
Comment 4 Zamir SUN 2015-06-12 05:44:43 UTC 
(In reply to Dan McPherson from comment #3)
> Is there anything left to fix?

My PR is merged on 19 Nov 2014. So I assume this is fixed.
Comment 5 Liang Xia 2015-06-15 03:06:05 UTC 
Verified on devenv_5549, the issue has been fixed.

#  oo-admin-cartridge --action install --source /tmp
install failed for /tmp: Cartridge manifest.yml missing: '/tmp/metadata/manifest.yml'

Operation failed: some cartridge cannot be installed


#  echo $?
1