Bug 1132392
Summary: | NFS interoperability problem: stripe-xlator removes EOF at end of READDIR | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Niels de Vos <ndevos> |
Component: | nfs | Assignee: | Niels de Vos <ndevos> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | low | Docs Contact: | |
Priority: | high | ||
Version: | 3.4.5 | CC: | bugs, gluster-bugs, kkeithle |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-04-13 07:05:09 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1130969 | ||
Bug Blocks: | 1125245 |
Description
Niels de Vos
2014-08-21 09:31:10 UTC
REVIEW: http://review.gluster.org/8510 (NFS: stripe-xlator should pass EOF at end of READDIR) posted (#1) for review on release-3.4 by Niels de Vos (ndevos) COMMIT: http://review.gluster.org/8510 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) ------ commit 1679b72c5b023884fb4bc6a2a85b06016fb3cab8 Author: Niels de Vos <ndevos> Date: Thu Aug 21 18:24:33 2014 +0200 NFS: stripe-xlator should pass EOF at end of READDIR NFS READDIR replies are made of a header, a sequence of entries, and a EOF flag. When GlusterFS's NFS server is used along with stripe xlator, it fails to set the EOF flag, which violates NFS RFC and confuses some clients. The bug is caused because nfs xlator sets EOF if it gets op_errno set to ENOENT. That value is produced in storage xlator and propagated through server, client, and other xlators until stripe xlator handles it. stripe only passed op_errno if op_ret < 0, which is not the case here. This change set adds a special case for that situation to fix the problem. Cherry picked from commit 9b5231e5c98b8cfa116838287c7a14042702795f: > Change-Id: Ie6db94b0515292387cfb04c1e4a9363f34fcd19a > BUG: 1130969 > Reported-by: Emmanuel Dreyfus <manu> > Signed-off-by: Niels de Vos <ndevos> > Reviewed-on: http://review.gluster.org/8493 > Tested-by: Gluster Build System <jenkins.com> > Reviewed-by: Santosh Pradhan <spradhan> > Reviewed-by: Kaleb KEITHLEY <kkeithle> > Reviewed-by: Emmanuel Dreyfus <manu> > Tested-by: Emmanuel Dreyfus <manu> Change-Id: Ie6db94b0515292387cfb04c1e4a9363f34fcd19a BUG: 1132392 Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/8510 Reviewed-by: Santosh Pradhan <spradhan> Tested-by: Gluster Build System <jenkins.com> |