Bug 1132451

Summary: [SNAPSHOT]: If the snapshoted brick has xfs options set as part of its creation, they are not automount upon reboot
Product: [Community] GlusterFS Reporter: Vijaikumar Mallikarjuna <vmallika>
Component: glusterdAssignee: Vijaikumar Mallikarjuna <vmallika>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: bugs, gluster-bugs, kparthas, rhinduja, smohan, ssamanta, vmallika
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: SNAPSHOT
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1132058
: 1145090 (view as bug list) Environment:
Last Closed: 2015-05-14 17:27:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1132058    
Bug Blocks: 1124583, 1145090    

Comment 1 Anand Avati 2014-08-21 11:42:54 UTC
REVIEW: http://review.gluster.org/8507 (glusterd: Parsing key/value pair with value contains '=') posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 2 Anand Avati 2014-08-21 11:55:44 UTC
REVIEW: http://review.gluster.org/8507 (glusterd: Parsing key/value pair with value contains '=') posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 3 Anand Avati 2014-08-21 11:55:51 UTC
REVIEW: http://review.gluster.org/8507 (glusterd: Parsing key/value pair with value containing '=') posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 4 Anand Avati 2014-08-21 13:28:45 UTC
COMMIT: http://review.gluster.org/8507 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit c1d722e4bce2d078c06d249cf186ecc77186d4af
Author: Vijaikumar M <vmallika>
Date:   Thu Aug 21 17:07:25 2014 +0530

    glusterd: Parsing key/value pair with value containing '='
    
    Parsing key/value pair in the brickinfo file, where value contains '='
    would truncate everything after '=' in value.
    
    For example:
    A key/value pair
    mnt-opts=rw,noatime,allocsize=1MiB,noattr2
    
    is parsed as:
    mnt-opts=rw,noatime,allocsize
    
    
    Change-Id: I4e279c2a356a8a16eb20d4358d7c8a8cc5724b65
    BUG: 1132451
    Signed-off-by: Vijaikumar M <vmallika>
    Reviewed-on: http://review.gluster.org/8507
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Sachin Pandit <spandit>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 5 Anand Avati 2014-08-25 05:32:11 UTC
REVIEW: http://review.gluster.org/8524 (glusterd: Parsing key/value pair with value containing '=') posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

Comment 6 krishnan parthasarathi 2014-08-25 06:00:29 UTC
Patch in comment#4 didn't make it into the repo due to a gerrit issue.

Comment 7 Anand Avati 2014-08-25 16:02:19 UTC
COMMIT: http://review.gluster.org/8524 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit ec257d019cacbe4998cc78b591fd5a212c8cff35
Author: Vijaikumar M <vmallika>
Date:   Thu Aug 21 17:07:25 2014 +0530

    glusterd: Parsing key/value pair with value containing '='
    
    Parsing key/value pair in the brickinfo file, where value contains '='
    would truncate everything after '=' in value.
    
    For example:
    A key/value pair
    mnt-opts=rw,noatime,allocsize=1MiB,noattr2
    
    is parsed as:
    mnt-opts=rw,noatime,allocsize
    
    BUG: 1132451
    Change-Id: I756b2fc4b06875267212b1a5c3e91c5a40c6accb
    Signed-off-by: Vijaikumar M <vmallika>
    Reviewed-on: http://review.gluster.org/8524
    Reviewed-by: Sachin Pandit <spandit>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 8 Niels de Vos 2015-05-14 17:27:15 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:35:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:37:55 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 11 Niels de Vos 2015-05-14 17:43:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user