Bug 1132729

Summary:	My Groups page has confusingly labelled buttons
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	web UI	Assignee:	Amit Saha <asaha>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.17	CC:	aigao, asaha, dcallagh, ebaak, rmancy, xma
Target Milestone:	0.18	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-04 05:40:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Callaghan 2014-08-21 23:38:30 UTC

Description of problem:
On the My Groups page, there are Remove and Add buttons which actually add or remove entire groups, even though you would expect that they are actually adding or removing your *membership* to a group.


Version-Release number of selected component (if applicable):
0.17

How reproducible:
easy

Steps to Reproduce:
1. Go to My Groups
2. See a group you want to remove yourself from
3. Click remove

Actual results:
Entire group is deleted

Expected results:
I am removed from the group

Additional info:

Comment 4 Amit Saha 2014-08-22 01:57:25 UTC

(In reply to Dan Callaghan from comment #0)
> Description of problem:
> On the My Groups page, there are Remove and Add buttons which actually add
> or remove entire groups, even though you would expect that they are actually
> adding or removing your *membership* to a group.

Just a note that, only admins will see the Remove button. I think may be have a separate button/link for "Remove my membership" or something of that sort.

Comment 5 Amit Saha 2014-08-24 00:21:47 UTC

(In reply to Amit Saha from comment #4)
> (In reply to Dan Callaghan from comment #0)
> > Description of problem:
> > On the My Groups page, there are Remove and Add buttons which actually add
> > or remove entire groups, even though you would expect that they are actually
> > adding or removing your *membership* to a group.
> 
> Just a note that, only admins will see the Remove button. I think may be
> have a separate button/link for "Remove my membership" or something of that
> sort.

While working on the patch, I realized that this is actually a new feature if we were to add it, so I have for now just renamed "Remove" to "Remove group" to fix this bug:

http://gerrit.beaker-project.org/#/c/3268/

Comment 6 matt jia 2014-08-24 23:24:40 UTC

My question is do we really need the remove button on this page since system admins can delete groups on the groups page? May be we should disable it for now to avoid future confusion.

Cheers,Matt Jia

Comment 7 Amit Saha 2014-08-25 00:16:18 UTC

Admin->Groups is only for admins, where as "My Groups" will also have groups you created or a co-owner of, and hence can remove them. Hence, if you are not an admin, there is no way you can remove a group from Admin->Groups.

Comment 8 Dan Callaghan 2014-08-25 00:19:49 UTC

A better label for the button might be "Delete Group". We use the word "remove" elsewhere but most other removals are easily undone (systems, lab controllers) whereas deleting a group is quite destructive and not easily reversible.

Comment 9 Amit Saha 2014-08-25 00:42:00 UTC

(In reply to Dan Callaghan from comment #8)
> A better label for the button might be "Delete Group". We use the word
> "remove" elsewhere but most other removals are easily undone (systems, lab
> controllers) whereas deleting a group is quite destructive and not easily
> reversible.

Sounds a good idea to me.

Comment 12 Dan Callaghan 2014-09-04 05:40:28 UTC

This bug fix was applied to the release-0.17 branch, but we are not doing any more maintenance releases of the 0.17.x series. So this bug is fixed in Beaker 0.18.0.