Bug 1132763

Summary:	[RFE] beaker-repo-update should ignore symlinks
Product:	[Retired] Beaker	Reporter:	Dan Callaghan <dcallagh>
Component:	general	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	develop	CC:	aigao, asaha, dcallagh, rmancy, xma
Target Milestone:	0.18	Keywords:	FutureFeature, Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-09-04 05:40:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Callaghan 2014-08-22 03:16:46 UTC

If you are importing a custom distro (MyRHEL6) then our recommended approach to getting a working harness repo will be to symlink that OS major name to an existing one, like RedHatEnterpriseLinux6.

We need to make sure beaker-repo-update will skip the repo and not barf on it.

Comment 2 Dan Callaghan 2014-08-26 00:32:22 UTC

Steps to reproduce:
1. Add a custom distro as per:
https://bugzilla.redhat.com/show_bug.cgi?id=1070597#c11
but instead of copying the harness repo using cp, symlink it using ln -s, so that it receives new packages.
2. Run beaker-repo-update.

Actual results:
beaker-repo-update spits out a warning like this, suggesting that the harness repo was not actually updated:

2014-08-26 10:30:51,668 bkr.server.tools.repo_update WARNING Cannot retrieve repository metadata (repomd.xml) for repository: http:--beaker-project.org-yum-harness-MyRedHatEnterpriseLinux6-. Please verify its path and try again

but in fact it *was* updated since the repo which it was symlinked to was updated correctly.

Expected results:
beaker-repo-update should skip symlinks entirely, so that you can symlink custom distro families to existing supported ones and beaker-repo-update won't complain for no reason.

Comment 3 Dan Callaghan 2014-08-26 00:42:53 UTC

On Gerrit: http://gerrit.beaker-project.org/3274

Comment 6 Dan Callaghan 2014-09-04 05:40:30 UTC

This bug fix was applied to the release-0.17 branch, but we are not doing any more maintenance releases of the 0.17.x series. So this bug is fixed in Beaker 0.18.0.