Bug 1133045
| Summary: | Use default path for modules when loading it trough kpatch | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Pablo Iranzo Gómez <pablo.iranzo> | |
| Component: | kpatch | Assignee: | Seth Jennings <sjenning> | |
| Status: | CLOSED ERRATA | QA Contact: | Linqing Lu <lilu> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | urgent | |||
| Version: | 7.0 | CC: | jherrman, jpoimboe, mmilgram, sauchter, sjenning | |
| Target Milestone: | rc | Keywords: | Reopened, ZStream | |
| Target Release: | 7.1 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | kpatch-0.1.10-2.el7 | Doc Type: | Bug Fix | |
| Doc Text: |
The kpatch interface now lists both loaded and installed patch modules by modprobe name, rather than by file name. This makes it more intuitive for users to load and unload installed modules.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1148851 (view as bug list) | Environment: | ||
| Last Closed: | 2015-03-05 13:40:25 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1148851 | |||
|
Description
Pablo Iranzo Gómez
2014-08-22 13:56:41 UTC
If you do a 'kpatch load kpatch_7_0_0_poc_el7_0.ko' (note the .ko) it works. This is misleading though since the list under 'Loaded patch modules' does not show the .ko. I can think of two things we could do: 1) If the user passes in a patch name without .ko, add it 2) Require the .ko but change the name under 'Loaded patch modules' to include .ko so that it is clearer that the .ko is part of the name. That also makes it match the 'Installed patch modules' output, which already displays the .ko. Another issue is that the filename with .ko removed doesn't exactly match the module name, because the kernel module code converts all '-' characters to '_'. I think we should do something similar to: 1) If the user passes in a patch name without .ko, add it with the additional feature of converting '_' to '-' where appropriate. Note that when converting from filename to module name, all '-' are converted to '_'. But the reverse is not true: when converting from module name to filename, not all '_' are necessarily converted to '-'. So when looking for a file to match the given module name, we'll have to do something like go through each installed file, convert '-' to '_', and compare with the given module name. Opened upstream issue https://github.com/dynup/kpatch/issues/371 Fix in upstream commit 1d63ce84932efda559d6d745930e1b05f446a334 included in v0.2.1. Reopening (still needs to be fixed in RHEL). I wouldn't say it is expected, but it doesn't keep this change from fixing the problem the bug describes; namely, inconsistent output between the "installed" and "loaded" list formats and load not accepting one of the list formats. Might be worth doing hyphen to underscore conversion in all cases though. I'll create a patch upstream. However, this nuance doesn't prevent the fix from addressing the issue in this bug. That makes sense to me. Thanks~ The major issue has been fixed for sure, and minor problem about hyphen/underscore consistency would be expected to fix in upstream. Please let me know if need a BZ to track the backport. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0296.html |