Bug 1133217
Summary: | Review Request: f21-backgrounds - Fedora 21 default desktop background | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Martin Sourada <martin.sourada> | |
Component: | Package Review | Assignee: | Pierre-YvesChibon <pingou> | |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | medium | Docs Contact: | ||
Priority: | medium | |||
Version: | rawhide | CC: | package-review, pingou | |
Target Milestone: | --- | Flags: | pingou:
fedora-review+
gwync: fedora-cvs+ |
|
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1196347 (view as bug list) | Environment: | ||
Last Closed: | 2014-08-28 09:48:48 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1196347 |
Description
Martin Sourada
2014-08-23 11:22:32 UTC
(In reply to Martin Sourada from comment #0) > URL will probably need to be created yet Scratch that, the URL is actually already up. Just out of curiosity, why not name it fedora-backgrounds with version which is equivalent to the current release number? (In reply to Christopher Meng from comment #2) > Just out of curiosity, why not name it fedora-backgrounds with version which > is equivalent to the current release number? We want users to be able to install and use wallpapers from past releases as well. * Spec is clean * License is CC-BY-SA ! Why the strange %version tag? I guess I can see a relation with Fedora 21 alpha, thus version is pre 21, but since the package is named f21, why not just use 0.1 for alpha, 0.2 for beta and 1.0 for release? ? You know probably better than I, but why is KDE having F21 while all the other desktops have f21? * builds fine on F20 * rpmlint: f21-backgrounds.noarch: W: no-documentation f21-backgrounds-kde.noarch: W: no-documentation f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1680x1050.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/640x480.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1024x768.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/2048x1536.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1024x600.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1440x900.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x720.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x768.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1920x1080.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1366x768.png ../../../../backgrounds/f21/default/tv-wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/800x480.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x1024.png ../../../../backgrounds/f21/default/normalish/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1152x864.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1600x1280.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x800.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1200x900.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/800x600.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1280x960.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1152x720.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1600x1200.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1920x1440.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1920x1200.png ../../../../backgrounds/f21/default/wide/f21.png f21-backgrounds-kde.noarch: W: dangling-relative-symlink /usr/share/wallpapers/F21/contents/images/1440x1080.png ../../../../backgrounds/f21/default/standard/f21.png f21-backgrounds-gnome.noarch: W: no-documentation f21-backgrounds-mate.noarch: W: no-documentation f21-backgrounds-xfce.noarch: W: no-documentation f21-backgrounds-xfce.noarch: W: dangling-relative-symlink /usr/share/xfce4/backdrops/f21.png ../../backgrounds/f21/default/wide/f21.png 6 packages and 0 specfiles checked; 0 errors, 29 warnings. http://fedoraproject.org/wiki/Common_Rpmlint_issues#dangling-relative-symlink says: > If your package contains both symlink and actual files, this can be safely ignored, otherwise please fix. Since we do contain the original files, we can ignore these. We can also ignore the lack of documentation (license file is pulled in by the base package) * f21-backgrounds-20.91.0.tar.xz (src.rpm) 7770ac0c65a2ee20b855fc7efca14f0d1a388acb7787fb1c7bb9fa1d5da5bbab f21-backgrounds-20.91.0.tar.xz sha512sum f21-backgrounds-20.91.0.tar.xz (upstream) 7770ac0c65a2ee20b855fc7efca14f0d1a388acb7787fb1c7bb9fa1d5da5bbab f21-backgrounds-20.91.0.tar.xz If you could answer the two comments at the top, I'll approve this package. (In reply to Pierre-YvesChibon from comment #4) > * Spec is clean > * License is CC-BY-SA > ! Why the strange %version tag? I guess I can see a relation with Fedora 21 > alpha, thus version is pre 21, but since the package is named f21, why not > just use 0.1 for alpha, 0.2 for beta and 1.0 for release? Just following the scheme from previous releases. It could be used for virtual versioned provides of system-backgrounds-gnome, etc.; we currently don't use that, but the possibility is there, with this versioning scheme. > ? You know probably better than I, but why is KDE having F21 while all the > other desktops have f21? > Again, for historical reasons. We are used to small caps, but back in the day when the -kde package used to be separate, they were using title case. Thus I keep using that for the F21 as well as we used it in previous releases with normal names. (In reply to Martin Sourada from comment #5) > (In reply to Pierre-YvesChibon from comment #4) > > * Spec is clean > > * License is CC-BY-SA > > ! Why the strange %version tag? I guess I can see a relation with Fedora 21 > > alpha, thus version is pre 21, but since the package is named f21, why not > > just use 0.1 for alpha, 0.2 for beta and 1.0 for release? > Just following the scheme from previous releases. It could be used for > virtual versioned provides of system-backgrounds-gnome, etc.; we currently > don't use that, but the possibility is there, with this versioning scheme. > > > ? You know probably better than I, but why is KDE having F21 while all the > > other desktops have f21? > > > Again, for historical reasons. We are used to small caps, but back in the > day when the -kde package used to be separate, they were using title case. > Thus I keep using that for the F21 as well as we used it in previous > releases with normal names. Fair enough. This package is APPROVED New Package SCM Request ======================= Package Name: f21-backgrounds Short Description: Fedora 21 desktop backgrounds Upstream URL: https://fedoraproject.org/wiki/F21_Artwork Owners: mso Branches: f21 InitialCC: design-sw Git done (by process-git-requests). Build done, present in repos now. |