Bug 1133315
| Summary: | Update to latest GParted in EL5 and EL6 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Mike Fleetwood <mike.fleetwood> | ||||||
| Component: | gparted | Assignee: | Mukundan Ragavan <nonamedotc> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | el6 | CC: | dakingun, nonamedotc | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | gparted-0.19.1-3.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-12-11 06:27:07 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1172549 | ||||||||
| Attachments: |
|
||||||||
How "easy" will back porting these fixes be? I don't think I can bump the major version on EL. I will check the updates policy again. (In reply to Mukundan Ragavan from comment #1) > How "easy" will back porting these fixes be? I don't think I can bump the > major version on EL. I will check the updates policy again. Hi Mukundan, I haven't tried to backport the above mentions fixes, but I suspect that after the first few it will become difficult and then impossible because of the other changes in GParted. (As I'm sure you've worked out) the above list of fixed data corruptions and crashes it about justifying upgrading to the latest upstream GParted under the EPEL policy referenced above. Thanks, Mike Hi Mike, I most certainly agree with you on the importance of pushing the newer version as an update. Let me check on the mailing list and verify dependencies before I push any updates - particularly to EL-5. :) Hi Mukundan, Any news on this. My apologies. I completely forgot about this. Let me set the ball rolling today. Hey Mike, quick question - Will updating to the latest Gparted on EL-5 and EL-6 result in breakage of scripts, etc? Will the end user experience be very different? I have used Gparted in EL6 and Fedora, I do not remember anything "surprising" me, but EL-5, I have not used. Your thoughts? Hi Mukundan,
There will be no breakages from updating to the latest GParted on EL-5
and EL-6.
1) No other packages depenend on the GParted package. It only
provides the GParted GUI program and the related help Manual,
icons, command line manual page, etc.
2) /usr/sbin/gparted is a shell script wrapper used to disable file
system automounting only while GParted is running. This is written
in a backwardly compatible way, maintaining support for older
methods: hal-lock and devkit-disks, while adding support for the
newer methods: udisks and systemctl.
The end user experience will be the same.
1) The UI in GParted 0.19.1 is the same as it was back in 0.4.8, and
even earlier.
2) GParted >= 0.6.0 by default creates partitions aligned to 1 MiB
where as earlier releases default to cylinder alignment. This is
just a combo box to select the required alignment in the Create New
Partition dialog. Very small difference for compared to
GParted 0.4.8 on EL-5.
Thanks,
Mike
Created attachment 955923 [details] gparted.spec for GParted 0.19.1 on EL6 Hi Mukundan, Here is the updated gparted.spec file for GParted 0.19.1 on EL6. Fetched from the GParted package repo and minimally updated. http://pkgs.fedoraproject.org/cgit/gparted.git/tree/gparted.spec?h=el6 Successfully built an RPM on my CentOS 6.6 box from this. Created attachment 955924 [details] gparted.spec and patches for GParted 0.19.1 on EL5 Here is the updated gparted.spec and patches for GParted 0.19.1 on EL5. Fetched from the GParted package repo and minimally updated. http://pkgs.fedoraproject.org/cgit/gparted.git/tree/gparted.spec?h=el5 Description of patches from the spec file: # Patch0: gparted-el5-intltool.patch # Required to compile GParted on EL5 with intltool 0.35.0. # Patch1: gparted-el5-ext3-default.patch # Recommended. Use ext3 as the default new file system rather than ext4 # as ext4 support was added later in optional package e4fsprogs. # Patch2: gparted-738706-e4fsprogs.patch # Recommended. Support ext4 tools from e4fsprogs package. Upstreamed # as GNOME#738706 in GParted > 0.20.0. I really would appreciate you releasing GParted 0.19.1 for EL5 and EL6. Thanks, Mike Doh. Missed a bit. Successfully built an RPM on my CentOS 5.11 box from the above. Since there was no big issues raised on epel-devel, I had planned to do this past week but could not. I should have it done this week. Thanks a lot for the patches. You have done most of my work! Just an update ... 0.19.1 does not build on EL-6. :( https://kojipkgs.fedoraproject.org//work/tasks/1487/8171487/build.log I will look at this soon. Error fragment:
./configure: line 15931: intltool-update: command not found
checking for intltool >= 0.35.5... found
configure: error: Your intltool is too old. You need intltool
0.35.5 or later.
error: Bad exit status from /var/tmp/rpm-tmp.IGqnHC (%build)
First two lines seem a little contradictory; intltool-update command not
found and intltool >= 0.35.5 found. Anyway, EPEL 6 comes with
intltool 0.41.0 so I assume that the buildroot environment isn't
including it by default. Recommend adding intltool to the BuildRequires
for the EL6 spec file. (Was previously added to the F15 and later spec
files). Expect to have to add it to the EL5 spec file too.
Thanks,
Mike
gparted-0.19.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gparted-0.19.1-1.el6 Package gparted-0.19.1-1.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing gparted-0.19.1-1.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2014-4145/gparted-0.19.1-1.el6 then log in and leave karma (feedback). Hi Mukundan, Just in case you haven't seen my feedback in Bodhi. There is a cosmetic issue: Package is version 0.19.1-1.el6, but the changelog is up to 0.19.1-2. Thanks, Mike Hi Mike, I saw that. When I do EL-5 update today or tomorrow, I will fix that as well! I will probably push a newer update and rescind this one. :) gparted-0.19.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/gparted-0.19.1-3.el6 Well, that's fixed! Now EL-5 remains! :) Rats! I will do this tomorrow! :( There seems to be some problem with building on EPEL-5 that I am trying to figure out. mock builds have been failing for a few days now. For example, https://koji.fedoraproject.org/koji/taskinfo?taskID=8325130 Hi Mukundan,
Never used mock but this looks strange. Package name trying to be built
is:
gparted-0.19.1-1.fc21.src.rpm
(including fc21)
yet the build logs appear to show it building on el5 as the build root
being constructed contains lots of packages named el5.
Sorry I can't be of more help,
Mike
Hi Mike, the src.rpm does not matter. It just reflects what system the source rpm was built on. I just wanted to give an update since I have not responded here. I will try to see what's really going on. No worries. gparted-0.19.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. Just a note - EL5 is not pushed yet. (In reply to Mukundan Ragavan from comment #25) > Just a note - EL5 is not pushed yet. gparted on EL-5 is being retired due to broken deps. I think this can be considered closed. |
Please update to the latest GParted, version 0.19.1, in EL5 and EL6. Since GParted 0.4.8 and 0.6.0, included in EL5 and EL6 respectively, there have been many data corruption and crashing fixes appled to GParted. I believe that this is inline with the EPEL policy which allows upstream upgrades in these cases. The policy says: Only updates that fix important bugs (say: data-corruption, security problems, really annoying bugs) http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Policy Here is the list of just these types of fixes I can identify from the GParted NEWS (http://www.gparted.org/news.php?item=all) and attached Release Notes: GParted 0.5.1 - Avoid crashes by ignoring devices with sector size > 512 bytes (Gnome#595309) 0.6.1 - Fix crash moving partition when size is a multiple of 16 MiB (Gnome#623697) 0.6.2 - Fix issue moving logical partition overwritting EBR (Gnome#623630) 0.6.3 - Prevent partition table creation if partitions are active (Ubuntu#50312) - Prevent swapon and mount if partition is in operation queue (Gnome#611431) 0.7.0 - Fix crash at start with glibmm-ERROR (Ubuntu#609477,Ubuntu#617885) - Fix crash moving more than one logical partition right (Gnome#628863) 0.9.0 - Fix GParted crashes with assertion (head_size <= 63) (Ubuntu#545911) 0.12.1 - Ensure space for EBR when resizing Extended partition (Gnome#664050) - Ensure Align to MiB does not overlap following partition (Gnome#661744) 0.14.0 - Fix crash when pressing Esc in dialogs with number entry (Gnome#682658) 0.14.1 - Fix logical partition grow overlaps extended partition end (Gnome#686668) 0.16.0 - Avoid crash in GParted when moving or copying partitions (Gnome#697727) 0.16.1 - Avoid another crash in GParted when moving or copying partitions (Gnome#697727) 0.16.2 - Fix crash if click apply before pending operations fully displayed (Gnome#699452) 0.17.0 - Fix busy detection for Linux Software RAID and extended partitions (Gnome#712633) 0.18.0 - Prevent crash when creating new partition on disk with loop label (Gnome#721988) 0.19.0 - Refactor OperationDetail to address random crash behavior (Gnome#729139) 0.19.1 - Prevent crash caused by cross thread write after free in _OnReadable() (Gnome#731752) Current GParted will build perfectly on EL6. A small patch will be required on EL5. Change the configure.ac script so that intltool 0.35.0 is considered acceptable: diff --git a/configure.ac b/configure.ac index 246e942..5ab71b2 100644 --- a/configure.ac +++ b/configure.ac @@ -31,7 +31,7 @@ AC_SUBST([GETTEXT_PACKAGE]) AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE], "$GETTEXT_PACKAGE", [description]) AM_GLIB_GNU_GETTEXT -IT_PROG_INTLTOOL([0.35.5]) +IT_PROG_INTLTOOL([0.35.0]) dnl====================== Then re-generate the configure script from configure.ac. Thanks, Mike Fleetwood (GParted Developer)