Bug 1134080

Summary: packstack mysql duplicate declaration
Product: Red Hat OpenStack Reporter: Jaroslav Henner <jhenner>
Component: openstack-packstackAssignee: Martin Magr <mmagr>
Status: CLOSED NOTABUG QA Contact: Ido Ovadia <iovadia>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 5.0 (RHEL 6)CC: aortega, derekh, rohara, sclewis, yeylon
Target Milestone: rcKeywords: Regression, Reopened
Target Release: 5.0 (RHEL 6)   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-27 12:27:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jaroslav Henner 2014-08-26 19:06:54 UTC
Description of problem:
packstack fails due to duplicate definition

2014-08-26 19:01:12 sshConnection - INFO - Error: Duplicate declaration: Service[mysqld] is already declared in file /var/tmp/packstack/d861e288985b4c6ab8cc978fa79d016e/manifests/172.16.32.28_mysql.pp:12; cannot redeclare at /var/tmp/packstack/d861e288985b4c6ab8cc978fa79d016e/modules/mysql/manifests/server.pp:52 on node jenkins-7e38a78a-7.novalocal


Version-Release number of selected component (if applicable):
openstack-packstack.noarch 0:2014.1.1-0.40.dev1239.el6ost will be installed

How reproducible:
1/1

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 5 Lon Hohberger 2014-08-26 19:59:11 UTC

*** This bug has been marked as a duplicate of bug 1129397 ***

Comment 6 Lon Hohberger 2014-08-26 20:16:12 UTC
So, the duplicate definition is here:

# on EL6 we need to wait for innodb changes before starting mysqld
if $::operatingsystem in ['RedHat','CentOS','Scientific'] and $::operatingsystemmajrelease < 7 {
    $manage_service = false
    service { 'mysqld':
      enable  => true,
      ensure  => 'running',
      require => [ Package['mysql-server'], File['/etc/my.cnf'] ],
      before  => Exec['set_mysql_rootpw'],
    }

If the comment is correct, I believe that it may be possible to simply remove the special-case for RHEL 6 at this point, since RHEL OSP 5 ships mariadb-galera-server 5.5.x, which has InnoDB as the default.

See also:

  https://bugzilla.redhat.com/show_bug.cgi?id=1129397#c10
  https://bugzilla.redhat.com/show_bug.cgi?id=1129397#c11

Comment 8 Ryan O'Hara 2014-08-26 20:34:44 UTC
I think the patch referenced here [1] is not needed. As mentioned in [2], it is pupept-galera that needs to disable mariadb/mysqld for HA. This has been patched in o-p-m.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1129397#c2
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1129397#c3