Bug 1134343
| Summary: | Review Request: perl-Digest-SHA3 - Perl extension for SHA-3 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Dick <ddick> |
| Component: | Package Review | Assignee: | Denis Fateyev <denis> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | denis, package-review |
| Target Milestone: | --- | Flags: | denis:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Digest-SHA3-0.22-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-10-08 19:01:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1134270 | ||
|
Description
David Dick
2014-08-27 11:06:15 UTC
koji builds rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7464985 el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=7464996 The URL and Source0 are usable. Ok.
The source archive is original (SHA-256: f2718f10b0acf5e5bd55c0e472115cf65c92f234984b018567329b5f1096ea2b). Ok.
Summary is Ok.
Description is Ok.
License verified from lib/Digest/SHA3.pm, src/sdf.c, src/sha3.c, src/sha3.h, sha3sum.
"You can redistribute it and/or modify it under the same terms as Perl itself."
GPL+ or Artistic. License is Ok.
XS code presents, arch is correct, debuginfo is usable: Ok.
Build-time dependencies are Ok.
All tests pass. Ok.
]$ rpmlint perl-Digest-SHA3-0.22-1.fc20.denf.src.rpm perl-Digest-SHA3-0.22-1.fc20.denf.x86_64.rpm perl-Digest-SHA3-debuginfo-0.22-1.fc20.denf.x86_64.rpm sha3sum-0.22-1.fc20.denf.noarch.rpm
perl-Digest-SHA3.x86_64: W: incoherent-version-in-changelog 0.22-1 ['0.22-1.fc20.denf', '0.22-1.denf']
4 packages and 0 specfiles checked; 0 errors, 1 warnings.
Omitting warning caused by RPM settings on my machine. Rpmlint is Ok.
$ rpm -q -lv -p perl-Digest-SHA3-0.22-1.fc20.denf.x86_64.rpm
drwxr-xr-x 2 root root 0 сен 29 04:06 /usr/lib64/perl5/vendor_perl/Digest
-rw-r--r-- 1 root root 16101 июн 1 13:15 /usr/lib64/perl5/vendor_perl/Digest/SHA3.pm
drwxr-xr-x 2 root root 0 сен 29 04:06 /usr/lib64/perl5/vendor_perl/auto/Digest
drwxr-xr-x 2 root root 0 сен 29 04:06 /usr/lib64/perl5/vendor_perl/auto/Digest/SHA3
-rwxr-xr-x 1 root root 28232 сен 29 04:06 /usr/lib64/perl5/vendor_perl/auto/Digest/SHA3/SHA3.so
drwxr-xr-x 2 root root 0 сен 29 04:06 /usr/share/doc/perl-Digest-SHA3
-rw-r--r-- 1 root root 3888 июн 1 13:15 /usr/share/doc/perl-Digest-SHA3/Changes
-rw-r--r-- 1 root root 1536 июн 1 13:15 /usr/share/doc/perl-Digest-SHA3/README
drwxr-xr-x 2 root root 0 сен 29 04:06 /usr/share/doc/perl-Digest-SHA3/examples
-rw-r--r-- 1 root root 1252 сен 29 04:06 /usr/share/doc/perl-Digest-SHA3/examples/dups3
-rw-r--r-- 1 root root 7287 сен 29 04:06 /usr/share/man/man3/Digest::SHA3.3pm.gz
$ rpm -q -lv -p sha3sum-0.22-1.fc20.denf.noarch.rpm
-rwxr-xr-x 1 root root 8573 сен 29 04:06 /usr/bin/sha3sum
drwxr-xr-x 2 root root 0 сен 29 04:06 /usr/share/doc/sha3sum
-rw-r--r-- 1 root root 1536 июн 1 13:15 /usr/share/doc/sha3sum/README
-rw-r--r-- 1 root root 2980 сен 29 04:06 /usr/share/man/man1/sha3sum.1.gz
File permissions and layout are Ok.
$ rpm -q --requires -p perl-Digest-SHA3-0.22-1.fc20.denf.x86_64.rpm | sort -f | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.14)(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.3.4)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libperl.so.5.18()(64bit)
1 perl >= 0:5.003000
1 perl(:MODULE_COMPAT_5.18.2)
1 perl(DynaLoader)
1 perl(Exporter)
1 perl(Fcntl)
1 perl(integer)
1 perl(strict)
1 perl(vars)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
$ rpm -q --requires -p sha3sum-0.22-1.fc20.denf.noarch.rpm | sort -f | uniq -c
1 /usr/bin/perl
1 perl(Digest::SHA3)
1 perl(Fcntl)
1 perl(Getopt::Long)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Requires are Ok.
$ rpm -q --provides -p perl-Digest-SHA3-0.22-1.fc20.denf.x86_64.rpm | sort -f | uniq -c
1 perl(Digest::SHA3) = 0.22
1 perl-Digest-SHA3 = 0.22-1.fc20.denf
1 perl-Digest-SHA3(x86-64) = 0.22-1.fc20.denf
$ rpm -q --provides -p sha3sum-0.22-1.fc20.denf.noarch.rpm | sort -f | uniq -c
1 sha3sum = 0.22-1.fc20.denf
Provides are Ok.
Package can be built successfully in Rawhide and EPEL7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=7716419
https://koji.fedoraproject.org/koji/taskinfo?taskID=7716423
Build is Ok.
Package is in line with Fedora and Perl packaging guidelines.
Review result: package is APPROVED.
Thanks Denis! New Package SCM Request ======================= Package Name: perl-Digest-SHA3 Short Description: Perl extension for SHA-3 Upstream URL: http://search.cpan.org/dist/Digest-SHA3/ Owners: ddick Branches: f20, f21, epel7, el6 InitialCC: perl-sig Git done (by process-git-requests). perl-Digest-SHA3-0.22-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Digest-SHA3-0.22-1.fc20 perl-Digest-SHA3-0.22-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Digest-SHA3-0.22-1.fc21 perl-Digest-SHA3-0.22-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Digest-SHA3-0.22-1.el6 perl-Digest-SHA3-0.22-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Digest-SHA3-0.22-1.el7 perl-Digest-SHA3-0.22-1.el7 has been pushed to the Fedora EPEL 7 testing repository. perl-Digest-SHA3-0.22-1.fc21 has been pushed to the Fedora 21 stable repository. perl-Digest-SHA3-0.22-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Digest-SHA3-0.22-1.el7 has been pushed to the Fedora EPEL 7 stable repository. perl-Digest-SHA3-0.22-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |